Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA: Filament's Notification and Profile menus are visible before 2FA is completed #334

Closed
jackwh opened this issue Feb 3, 2024 · 2 comments · Fixed by #356
Closed

2FA: Filament's Notification and Profile menus are visible before 2FA is completed #334

jackwh opened this issue Feb 3, 2024 · 2 comments · Fixed by #356

Comments

@jackwh
Copy link
Contributor

jackwh commented Feb 3, 2024

After entering their username and password, the user is taken to the 2FA screen. This didn't use to show anything more than the token input field, but recently I noticed the Notification and Profile menus have now started appearing.

You can click to access them and open notifications, despite the user not having completed 2FA. I'm not sure if something changed in Filament core or elsewhere as this just seemed to show up after running composer update recently.

@binaryfire
Copy link

Hi @jackwh. I'm having the same problem. Did you figure out a solution?

@jackwh
Copy link
Contributor Author

jackwh commented Mar 28, 2024

@binaryfire Thanks for your Filament PR! 👍 I just submitted #356 to make your fix permanent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants