Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of 'song_other' #422

Closed
laker-93 opened this issue Dec 26, 2023 · 2 comments
Closed

Add definition of 'song_other' #422

laker-93 opened this issue Dec 26, 2023 · 2 comments

Comments

@laker-93
Copy link

laker-93 commented Dec 26, 2023

Missing entity string definition of 'song_other' in locales. Example from en.json here. other languages seem to be missing it too:

"success": "added {{message}} $t(entity.song_other) to {{numOfPlaylists}} $t(entity.playlist_other)",

@laker-93
Copy link
Author

I think this is also broken: https://github.com/jeffvli/feishin/blob/development/src/renderer/features/playlists/components/add-to-playlist-context-modal.tsx#L199

The form attribute should be:

'form.addToPlaylist.success'

@kgarner7
Copy link
Collaborator

Resolved by #473! The correct field is track_other. Practically though, it would be nice to use the pluralized form with count where appropriate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants