Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from Youtube in embed code, need to adapt a specific line in Mercury #452

Open
thomasmalbaux opened this issue Apr 11, 2014 · 0 comments

Comments

@thomasmalbaux
Copy link

thomasmalbaux commented Apr 11, 2014

Youtube embed code no longer specify the protocol (see that Google Group discussion: https://productforums.google.com/forum/#!topic/youtube/U8td_YIrbCQ).
When I try to add a youtube video in Mercury via Media > Youtube url, it fails. Workaround is to edit html code and remove the "http:" or use Youtube embed code directly.

I feel that this line (https://github.com/jejacks0n/mercury/blob/master/app/assets/javascripts/mercury/modals/insertmedia.js.coffee#L118) should be updated and the protocol variable removed or improved. I'm dont feel confident to do it so I hope raising the issue and potential clue to solve it will help :-)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1597530-change-from-youtube-in-embed-code-need-to-adapt-a-specific-line-in-mercury?utm_campaign=plugin&utm_content=tracker%2F134071&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F134071&utm_medium=issues&utm_source=github).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant