Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab press after metafield name should jump to value #412

Open
mariusa opened this issue Jul 14, 2017 · 3 comments
Open

Tab press after metafield name should jump to value #412

mariusa opened this issue Jul 14, 2017 · 3 comments

Comments

@mariusa
Copy link

mariusa commented Jul 14, 2017

Edit a page
Click new metafield
Enter name
Press Tab

Expected:
Tab press should jump to next field, value

Result:
Focus jumps to Save button

@mertkahyaoglu
Copy link
Member

Hmm. This is because newly created metafields do not have tabindex attribute.

@ashmaroli
Copy link
Member

What's weird is that this bug occurs only when the key-field is changed..

Case 1:

  1. Create new metafield
  2. Press Tab

Result: The assoc. .value-field gets focused.


Case2:

  1. Create new metafield
  2. Click anywhere outside .key-field
  3. Click-to-Focus .key-field
  4. Press Tab

Result: The assoc. .value-field gets focused.


Case 3:

  1. Create new metafield
  2. Change label
  3. Press Tab

Result: The assoc. .value-field does not get focused.


Case 4:

  1. Create new metafield
  2. Change label
  3. Lose focus on .key-field by clicking elsewhere.
  4. Click to re-focus .key-field
  5. Press Tab

Result: The assoc. .value-field gets focused.

@jekyllbot
Copy link

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants