name: null in ld+json

[chrislovecnm]

Not sure if this is expected, but I am getting this output from my site:

{
	"name": null,
	"description": "Choosing which CNI provider to deploy in Kubernetes",
	"author": {
		"@type": "Person",
		"name": "Chris Love     - chrislovecnm"
	},
	"@type": "BlogPosting",
	"url": "https://chrislovecnm.com/kuberentes/cni/choosing-a-cni-provider/",
	"publisher": null,
	"image": "https://chrislovecnm.com/img/cni-logo.png",
	"headline": "Choosing a CNI Provider for Kubernetes",
	"dateModified": "20    17-11-11T18:22:52-07:00",
	"datePublished": "2017-11-11T18:22:52-07:00",
	"sameAs": null,
	"mainEntityOfPage": {
		"@type": "WebPage",
		"@id": "https://chrislovecnm.com/kuberentes/cni/choosing-a-cni-provider/"
	},
	"@context": "http://schema.org"
}

[benbalter]

jekyll-seo-tag/lib/jekyll-seo-tag/drop.rb

Lines 58 to 69 in 232d9f9

	def name
	return @name if defined?(@name)
	@name = if seo_name
	seo_name
	elsif !homepage_or_about?
	nil
	elsif site_social["name"]
	format_string site_social["name"]
	elsif site_title
	site_title
	end
	end

is the relevant line. Assuming this is the homepage or about page, I believe it's intentional?

[chrislovecnm]

This page is a post, not the home or about. How is seo_name set?

[chrislovecnm]

I wonder if index.html is picking it up. All my permalinks are index.html

[benbalter]

All my permalinks are index.html

Can you explain what you mean? Is your repository public?

[chrislovecnm]

https://github.com/chrislovecnm/chrislovecnm.com
The HTML pages on my blog are all named index.html. Is the plunging matching it as a homepage?

[benbalter]

@chrislovecnm this is technically the intended behavior, at least as the logic is implemented in

jekyll-seo-tag/lib/jekyll-seo-tag/drop.rb

Lines 62 to 63 in 232d9f9

	elsif !homepage_or_about?
	nil

.

I'm not sure, however, is this is the correct JSON-LD implementation. A quick google search suggests the name field is only used as a top-level element when the type is @organization, which would make sense to only display it on the homepage or about page.

I confirmed, however, that it is not displaying null because the page is e.g., /foo/index.html.

[jekyllbot]

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

[pathawks]

Fixed via #249