-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site.config['url'] should be respected regardless of environment #5488
Comments
Hi, have you tried to set your |
|
To be clear, I never had any issue serving my site locally with that value set prior to 3.3 release. |
Can you explain your issue a bit more? I'm not sure I understand. |
My issue is that I don't understand why you can't read the explicitly set value of config and it not be hijacked, regardless of environment. While never had a problem with To clarify, the plugin will always want the domain url for that cache file. |
You are still able to set a local url via the
Would give you |
So to be clear, serving locally, the only way to read the |
Ok, I was more trying to understand your workflow to see if there were a better way to go about things. I guess the bottom line is that Jekyll is working as intended, and this is not a bug. |
I agree with @miklb - this is really unintuitive. I spent a good deal of time debugging this behaviour as well. I would expect the variable to return the data that is contained there, not to coerce it into something that it believes is more accurate. |
Jekyll lives by the 80% rule, default behavior is documented here: |
github-pages
My Reproduction Steps
I am using a plugin that stores all links in a post in a .cache file under
source
, the url of the post containing them for further processing. Specifically, the plugin usessite.config['url']
& the permalink. In 3.3, this breaks, writinghttp://localhost:4000
instead of the value in config.The Output I Wanted
Respect the value of the config file.
The text was updated successfully, but these errors were encountered: