Crash results from recently added media if .mp4 video files have embedded chapters #2125
Labels
bug
Something isn't working
confirmed
Issue can be reproduced
crash
Bug causing app crashes
sdk-migration
To fix this we need to migrate some code to the new SDK
Comments
mikewesten
changed the title
|
I was about to post a very similar issue when I saw this. I've been able to reproduce a similar crash by adding a subtitles file. For example, if I add "Marley & Me (2008).eng.srt" to the movie directory, along with updated NFO file created by Tiny Media Manager, I get a very similar stack trace. I'm running Jellyfin 10.8.5 and jellyfin-androidtv 0.14.3 on an Nvidia Shield. I'm happy to post a log, if it's helpful. This issue is also being discussed at: |
|
This was a result of the api changes in jellyfin/jellyfin#8298 added in 10.8.5 being incompatible with some of the old code in the app. We're planning to get a fix out soon! |
nielsvanvelzen
added
confirmed
This was referenced Oct 4, 2022
|
I have a potential fix for this issue in #2139 but I'm unable to test it. If anyone experiences this issue wants to help out you can do the following:
APK Download: https://github.com/jellyfin/jellyfin-androidtv/suites/8606729121/artifacts/385968954 |
|
8 second generic Jellyfin Preroll video, with silent AAC audio Containing menu stream: Does not contain menu stream: |
|
Thanks a lot @mikewesten! I was able to reproduce the crash and can confirm that my fix works. Will make a new app release ASAP. |
That's good. I don't know how helpful or relevant this might be but here's the same menu-stream-containing video remuxed to an .mkv container. It completely eliminates the issue on my end. |
|
My personal libraries are 100% MKV files and from what I could find the matroska specification doesn't have data streams. So that's why it doesn't trigger the issue with mkv files. A new version of the app is now released and we're pushing it to Google Play and the Amazon Appstore. They need to review it and that can sometimes take a few days. |
|
Thank you, that was quick. I've just downloaded it and "update over'd" my v0.14.3 to v0.14.4 via sideload. Here's the log:
|
|
Looks like that issue only happens in the current 0.14 branch. A workaround should be to disable debugging options in the advanced preferences. I'm looking into a proper fix now. |
|
New build is running now (reused the same version) with a fix. When testing I did it on our master branch which includes all the changes for the next 0.15 version where the issue did not happen. I've backported a change from some time ago (#1997) to fix in in 0.14 too. |
|
To follow up... As for the test sample video ''Jellyfin Prerolls + Menu Stream.mp4' still being subject to a crash... Edit: Or if I put that video test sample into a 'Photos' library, that also works. No crashes there. Issue resolved as far as I'm corncerned. Upwards and onwards. 👍 |
This was referenced Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When adding new media to movie library in the form of an .mp4 video file with embedded menu stream/timed text chapters, it results in an Android TV app crash when that item is selected from the 'Latest Movies' row... and also when the movie library itself is selected from the 'My Media' row. The former action results in the movie's backdrop being displayed but remains stuck with nothing else loading except the user avatar and the clock on the top right corner. From here the user can only use the back button and the app then crashes. The latter action of selecting the movie library from the 'My Media' row results in an immediate crash.
This behavior does not occur in the web app or native app, the media is fully navigable, viewable, and playable, and embedded chapters of aforementioned .mp4 video file are fully seekable.
(On Android TV app) I am able to resolve this issue by re-adding the media item as either an .mp4 file with embedded chapters removed, or by an re-adding it as an .mkv file with those very same embedded chapters. When doing either of these two things, the crash ceases to occur. Alternatively, the problematic media item can simply be removed entirely without replacement, and then selecting movie library from the 'My Media' row will no longer result in a crash, instead it loads normally again.
I should note that this issue only began occurring after a recent server update to v10.8.5
And it seems to only affect new media additions. Previously added .mp4 video files with embedded chapters are unaffected somehow. Those media items can be selected, viewed, and played back normally, with no crashes and no issues.
Mediainfo of a problematic video file is as follows
`General
Complete name : Media/Movies/The Willies (1990)/The.Willies.1990.DVDRip.x264-HANDJOB.mp4
Format : MPEG-4
Format profile : Base Media
Codec ID : isom (isom/iso2/avc1/mp41)
File size : 2.04 GiB
Duration : 1 h 31 min
Overall bit rate : 3 206 kb/s
Movie name : The Willies
Writing application : Lavf58.29.100
Comment : The.Willies.1990.DVDRip.x264-HANDJOB
Video
ID : 1
Format : AVC
Format/Info : Advanced Video Codec
Format profile : High@L4
Format settings : CABAC / 16 Ref Frames
Format settings, CABAC : Yes
Format settings, Reference frames : 16 frames
Codec ID : avc1
Codec ID/Info : Advanced Video Coding
Duration : 1 h 31 min
Bit rate : 2 753 kb/s
Width : 704 pixels
Height : 480 pixels
Display aspect ratio : 4:3
Original display aspect ratio : 4:3
Frame rate mode : Constant
Frame rate : 23.976 (24000/1001) FPS
Color space : YUV
Chroma subsampling : 4:2:0
Bit depth : 8 bits
Scan type : Progressive
Bits/(Pixel*Frame) : 0.340
Stream size : 1.75 GiB (86%)
Writing library : x264 core 142 r2479 dd79a61
Encoding settings : cabac=1 / ref=16 / deblock=1:-3:-3 / analyse=0x3:0x133 / me=umh / subme=10 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=32 / chroma_me=1 / trellis=2 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=0 / chroma_qp_offset=-2 / threads=12 / lookahead_threads=1 / sliced_threads=0 / nr=0 / decimate=0 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=5 / b_pyramid=2 / b_adapt=2 / b_bias=0 / direct=3 / weightb=1 / open_gop=0 / weightp=2 / keyint=240 / keyint_min=24 / scenecut=40 / intra_refresh=0 / rc_lookahead=60 / rc=crf / mbtree=0 / crf=18.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / vbv_maxrate=25000 / vbv_bufsize=31250 / crf_max=0.0 / nal_hrd=none / filler=0 / ip_ratio=1.40 / pb_ratio=1.30 / aq=1:1.00
Color range : Limited
Color primaries : BT.601 NTSC
Transfer characteristics : BT.709
Matrix coefficients : BT.601
Menus : 3
Codec configuration box : avcC
Audio
ID : 2
Format : AC-3
Format/Info : Audio Coding 3
Commercial name : Dolby Digital
Codec ID : ac-3
Duration : 1 h 31 min
Bit rate mode : Constant
Bit rate : 448 kb/s
Channel(s) : 6 channels
Channel layout : L R C LFE Ls Rs
Sampling rate : 48.0 kHz
Frame rate : 31.250 FPS (1536 SPF)
Compression mode : Lossy
Stream size : 292 MiB (14%)
Language : English
Service kind : Complete Main
Default : Yes
Alternate group : 1
Menus : 3
Menu
ID : 3
Format : Timed Text
Codec ID : text
Duration : 1 h 31 min
Language : English
Menu For : 1,2
00:00:00.000 : Grosser Than Gross
00:12:59.112 : Back In The Day
00:23:40.169 : Scary Stall
00:31:29.096 : Back For Seconds
00:40:48.655 : Gordy Belcher
00:51:37.136 : Experiments
00:58:39.599 : Truth Televised
01:08:30.398 : Being Mean
01:16:35.800 : Spivey's Gift
01:24:55.465 : What's Real`
Logs
CRASH #1 (selecting item from 'Latest Movies')
client: Jellyfin for Android TV
client_version: 0.14.3
client_repository: https://github.com/jellyfin/jellyfin-androidtv
type: crash_report
format: markdown
Logs
Stack Trace:
Logcat:
App information
App version:
0.14.3(140399)Package name:
org.jellyfin.androidtvBuild:
{"BOARD":"mantis","BOOTLOADER":"unknown","BRAND":"Amazon","CPU_ABI":"armeabi-v7a","CPU_ABI2":"armeabi","DEVICE":"mantis","DISPLAY":"NS6280","FINGERPRINT":"Amazon\/mantis\/mantis:6.0\/NS6280\/3236N:user\/amz-p,release-keys","HARDWARE":"mt8695","HOST":"i3-ri-14-use1a-b-80","ID":"NS6280","IS_DEBUGGABLE":false,"IS_EMULATOR":false,"MANUFACTURER":"Amazon","MODEL":"AFTMM","PERMISSIONS_REVIEW_REQUIRED":false,"PRODUCT":"mantis","RADIO":"unknown","REQ_BATTERY_LEVEL":0.3,"SUPPORTED_32_BIT_ABIS":["armeabi-v7a","armeabi"],"SUPPORTED_64_BIT_ABIS":[],"SUPPORTED_ABIS":["armeabi-v7a","armeabi"],"TAGS":"amz-p,release-keys","TIME":1621639613000,"TYPE":"user","UNKNOWN":"unknown","USER":"build","VERSION":{"ACTIVE_CODENAMES":[],"BASE_OS":"NHG47K","CODENAME":"REL","INCREMENTAL":"0005067547780","PREVIEW_SDK_INT":0,"RELEASE":"7.1.2","RESOURCES_SDK_INT":25,"SDK":"25","SDK_INT":25,"SECURITY_PATCH":"2019-09-01"}}Build config:
{"APPLICATION_ID":"org.jellyfin.androidtv","BUILD_TYPE":"release","DEBUG":false,"DEVELOPMENT":false,"VERSION_CODE":140399,"VERSION_NAME":"0.14.3"}Device information
Android version:
7.1.2Device brand:
AmazonDevice product:
mantisDevice model:
AFTMMCrash information
Start time:
2022-09-29T15:04:06.091-07:00Crash time:
2022-09-29T15:05:05.750-07:00CRASH #2 (selecting movie library from the 'My Media' row)
client: Jellyfin for Android TV
client_version: 0.14.3
client_repository: https://github.com/jellyfin/jellyfin-androidtv
type: crash_report
format: markdown
Logs
Stack Trace:
Logcat:
App information
App version:
0.14.3(140399)Package name:
org.jellyfin.androidtvBuild:
{"BOARD":"mantis","BOOTLOADER":"unknown","BRAND":"Amazon","CPU_ABI":"armeabi-v7a","CPU_ABI2":"armeabi","DEVICE":"mantis","DISPLAY":"NS6280","FINGERPRINT":"Amazon\/mantis\/mantis:6.0\/NS6280\/3236N:user\/amz-p,release-keys","HARDWARE":"mt8695","HOST":"i3-ri-14-use1a-b-80","ID":"NS6280","IS_DEBUGGABLE":false,"IS_EMULATOR":false,"MANUFACTURER":"Amazon","MODEL":"AFTMM","PERMISSIONS_REVIEW_REQUIRED":false,"PRODUCT":"mantis","RADIO":"unknown","REQ_BATTERY_LEVEL":0.3,"SUPPORTED_32_BIT_ABIS":["armeabi-v7a","armeabi"],"SUPPORTED_64_BIT_ABIS":[],"SUPPORTED_ABIS":["armeabi-v7a","armeabi"],"TAGS":"amz-p,release-keys","TIME":1621639613000,"TYPE":"user","UNKNOWN":"unknown","USER":"build","VERSION":{"ACTIVE_CODENAMES":[],"BASE_OS":"NHG47K","CODENAME":"REL","INCREMENTAL":"0005067547780","PREVIEW_SDK_INT":0,"RELEASE":"7.1.2","RESOURCES_SDK_INT":25,"SDK":"25","SDK_INT":25,"SECURITY_PATCH":"2019-09-01"}}Build config:
{"APPLICATION_ID":"org.jellyfin.androidtv","BUILD_TYPE":"release","DEBUG":false,"DEVELOPMENT":false,"VERSION_CODE":140399,"VERSION_NAME":"0.14.3"}Device information
Android version:
7.1.2Device brand:
AmazonDevice product:
mantisDevice model:
AFTMMCrash information
Start time:
2022-09-29T15:06:01.373-07:00Crash time:
2022-09-29T15:06:09.242-07:00Application version
0.14.3
Where did you install the app from?
Sideloaded APK
Device information
Amazon Fire Stick 4k
Android version
Fire OS 6.2.8.0 / Wolf Launcher v0.1.9-Wolf
Jellyfin server version
10.8.5
The text was updated successfully, but these errors were encountered: