Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding audio / subtitles sync menu in ExoPlayer (adjust audio / subtitles sync functionality) #2479

Open
MSTRKKRFT opened this issue Feb 7, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@MSTRKKRFT
Copy link

MSTRKKRFT commented Feb 7, 2023

Describe the feature you'd like

Hello!

I noticed that libVLC player allows adjusting audio & subtitles sync, which is great as depending on the file format I have different audio delays. Sometimes the file will play just fine without sync issue, but with Dolby Vision files, for example, I need to add 350ms delay to get audio in sync.

Because of that (and problems with subtitles in ExoPlayer, as described here : #2374 (comment)), I have to use Kodi as external player if I want to use Jellyfin ATV app, but with that solution watch state tracking is not working, so I would prefer to be able to use ExoPlayer inside jellyfin app.

Is it possible to add this option in ExoPlayer as well ?

@MSTRKKRFT MSTRKKRFT added the enhancement New feature or request label Feb 7, 2023
@tim-vk
Copy link
Contributor

tim-vk commented Feb 7, 2023

It's been a while but I'm the guy who added the subtitle sync to the libVLC player and at that time I could not find a plug-and-play method to get subtitle offsets working in exoplayer. See here.

However!

I saw a very interesting conversation here where I maybe oversaw a very simple solution for that. So that's something I can maybe take a look at.

I don't have the slightest idea how the audio sync would work: haven't looked at that.

By the way: Your link is dead. Could you check it?

Edit: Did a quick check. I think getting the subtitle offset to work with external subtitles shouldn't be a problem (just add the buttons & ensure 'getsubtitledelay' returns the correct value). However subtitle offset with internal subtitles would still be an issue (since exoplayer doesn't support offsets).

@MSTRKKRFT
Copy link
Author

First, thanks for your work!
I'm not a dev, so I really can't help you on that… But if you need any end-user testing or something, I would be glad to help you.
Just updated the link ! The problem is integrated subs & Dolby Vision aren't playing great together in jellyfin-exoplayer, but no issue with kodi-exoplayer (maven's build from kodinerds)

@zerodogg

This comment was marked as off-topic.

@jdumeez

This comment has been minimized.

@itsZeebo

This comment has been minimized.

@M4TH1EU

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants