Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back setting to set a more precise font size #4173

Closed
laurentlbm opened this issue Nov 5, 2024 · 4 comments · Fixed by #4175
Closed

Add back setting to set a more precise font size #4173

laurentlbm opened this issue Nov 5, 2024 · 4 comments · Fixed by #4175
Labels
enhancement New feature or request

Comments

@laurentlbm
Copy link

Describe the feature you'd like

The new beta (0.18.0-beta.1) changed how subtitles are rendered. Unfortunately, it also removed the option to specify a font size (10-38), replacing it with relative sizes (very small, small, normal, large, very large). I use a projector, so my display is pretty large, and I find Normal to be too big, and Small too small...

In fact, I can see that Small is set to be half the size of Normal. That's a pretty big jump in between values. Could a more granular scale be offered?

@laurentlbm laurentlbm added the enhancement New feature or request label Nov 5, 2024
@nielsvanvelzen
Copy link
Member

Some subtitle formats allow customization of the text size, therefor we longer have an "absolute" size and instead use fractional sizing. I've opted to use a list of options instead of a slider because it's more intuitive (the slider control is not great for this type of value). The possible options for this list are copied from Android itself: https://cs.android.com/android/platform/superproject/main/+/main:packages/apps/Settings/res/values/arrays.xml;l=712-728;drc=5484c1e2136559a7c83b79049dc7dc6a5a68123b

@laurentlbm
Copy link
Author

I understand. The font size of captions has been a frequent annoyance for me in other apps that also use Android's default scale. I guess I'm very superficial and care too much about the appearance of subtitles! I'll probably get used to it; it was just a shock going from 0.17 to 0.18.

FYI, out of curiosity I looked at how some other streaming apps handle sizes:

  • Netflix offers 3 sizes: Small, Medium and Large. Medium looks to me a little bit smaller than Jellyfin's normal. Small is 0.5x medium and large is 2x medium.
  • Disney+ uses Android's settings (Accessibility > Captions), so sizing is similar to Jellyfin.
  • Nebula has no options. Size seems to be the same as Jellyfin's normal.
  • SmartTube allows the user to select a font size scale from a list going from 0.1x to 2x in 0.1x increments. Great for customizability, but maybe not for usability!

@nielsvanvelzen
Copy link
Member

I've made some changes and used the behavior of SmartTube as basis. You can now set the text size with a slider going from 25% up to 250% with increments of 25%. This allows for all previous values but adds a bit more variety, 75% would be between what previously was small (50%) and normal (100%).

Image

Thanks for the feedback!

@laurentlbm
Copy link
Author

That's amazing, thank you very much! I'm certain that 75% will be perfect for me, in SmartTube I have it set to 0.7x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants