-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back setting to set a more precise font size #4173
Comments
Some subtitle formats allow customization of the text size, therefor we longer have an "absolute" size and instead use fractional sizing. I've opted to use a list of options instead of a slider because it's more intuitive (the slider control is not great for this type of value). The possible options for this list are copied from Android itself: https://cs.android.com/android/platform/superproject/main/+/main:packages/apps/Settings/res/values/arrays.xml;l=712-728;drc=5484c1e2136559a7c83b79049dc7dc6a5a68123b |
I understand. The font size of captions has been a frequent annoyance for me in other apps that also use Android's default scale. I guess I'm very superficial and care too much about the appearance of subtitles! I'll probably get used to it; it was just a shock going from 0.17 to 0.18. FYI, out of curiosity I looked at how some other streaming apps handle sizes:
|
I've made some changes and used the behavior of SmartTube as basis. You can now set the text size with a slider going from 25% up to 250% with increments of 25%. This allows for all previous values but adds a bit more variety, 75% would be between what previously was small (50%) and normal (100%). Thanks for the feedback! |
That's amazing, thank you very much! I'm certain that 75% will be perfect for me, in SmartTube I have it set to 0.7x. |
Describe the feature you'd like
The new beta (0.18.0-beta.1) changed how subtitles are rendered. Unfortunately, it also removed the option to specify a font size (10-38), replacing it with relative sizes (very small, small, normal, large, very large). I use a projector, so my display is pretty large, and I find
Normal
to be too big, andSmall
too small...In fact, I can see that
Small
is set to be half the size ofNormal
. That's a pretty big jump in between values. Could a more granular scale be offered?The text was updated successfully, but these errors were encountered: