Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles have a different shadow than my settings #5602

Open
JVT038 opened this issue May 24, 2024 · 13 comments · May be fixed by #5737
Open

Subtitles have a different shadow than my settings #5602

JVT038 opened this issue May 24, 2024 · 13 comments · May be fixed by #5737
Labels
bug Something isn't working

Comments

@JVT038
Copy link

JVT038 commented May 24, 2024

Describe The Bug
When I play something, the subtitles have this shadow that look like a drop shadow, even though I changed it to 'uniform' in the settings.

Steps To Reproduce

  1. Go to personal settings
  2. Click on subtitles
  3. Scroll down to drop shadow
  4. Set to 'Uniform'
  5. Save
  6. Play a video
  7. See error

Expected Behavior
I expected the subtitles to look like the 'uniform' subtitles

Screenshots
This is the subtitle I expect:
image
And this is the subtitle I get:
image

System (please complete the following information):

  • Platform: Windows 10
  • Browser: Firefox
  • Jellyfin Version: 10.9.2

Logs
I don't know if these errors are relevant, but they show up in the browser console.

HLS Error: Type: otherError Details: internalException Fatal: false main.jellyfin.bundle.js:2:73451
ReferenceError: t is not defined 38932f0f-23f6-4806-8cad-44df1f497289:1:100
HLS Error: Type: mediaError Details: bufferFullError Fatal: false 3 main.jellyfin.bundle.js:2:73451
HLS Error: Type: mediaError Details: bufferFullError Fatal: false

Additional Context
The subtitle type in the screenshot is subrip.
Additionally, this error does not occur when using the Jellyfin Media Player desktop app (which is supposed to be a wrapper of the website right?)

@JVT038 JVT038 added the bug Something isn't working label May 24, 2024
@thornbill
Copy link
Member

thornbill commented May 24, 2024

Duplicate of #5592

Actually I don't think this is a duplicate... are you using any custom css?

@thornbill thornbill marked this as a duplicate of #5592 May 24, 2024
@thornbill thornbill closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
@thornbill thornbill added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels May 24, 2024
@thornbill thornbill reopened this May 24, 2024
@JVT038
Copy link
Author

JVT038 commented May 24, 2024

Yeah, I'm using the ultrachromic styles.
This is the custom CSS:

@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/progress/floating.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/titlepage/title_simple-logo.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/type/dark.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/cornerindicator/indicator_floating.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/fields/fields_border.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/login/login_frame.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/episodelist/episodes_compactlist.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/rounding.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/base.css');@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/accentlist.css');@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/fixes.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/smallercast.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/header/header_transparent.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/effects/hoverglow.css');
@import url('https://ctalvio.github.io/Monochromic/backdrop-hack_style.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/fixes.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/smallercast.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/header/header_transparent.css');
@import url('https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/effects/hoverglow.css');
@import url('https://ctalvio.github.io/Monochromic/backdrop-hack_style.css');
:root {--accent: 98.00787045,121.00999580324999,204.99450000000002;}
.backdropImage {filter: blur(30px);}
.backdropImage {filter: saturate(120%);}
.backdropImage {filter: contrast(120%);}
.backdropImage {filter: brightness(40%);}
:root {--rounding: 12px;}

I have removed all the custom CSS, and the problem still persists. So I don't think it's caused by the custom CSS.

@z1R
Copy link

z1R commented May 24, 2024

I'm having the same problem. Also on Firefox.

@thornbill
Copy link
Member

@z1R are you using any custom css?

@z1R
Copy link

z1R commented May 24, 2024

@thornbill yes but like the original poster it makes no difference if I remove the custom css or not.

@AmiSapphire
Copy link

I'm not using any custom CSS and this is reproducible here. Using Firefox.

@kam821
Copy link

kam821 commented Jun 2, 2024

Same problem here.
The subtitles seem to respond to vertical position change, but not to changes in size/shadow setting.

@JamsRepos
Copy link

Same problem here. The subtitles seem to respond to vertical position change, but not to changes in size/shadow setting.

Yup, i'm getting the same. You can change all settings that change the way subtitles display, the only property that changes is the verticial position.

Text size, Text weight, Font, Colour, Shadow all do not work. This is present on Firefox. It seems it works on Edge and Chrome, from what i've tested.

@venkat-karasani
Copy link
Contributor

identified the issue, will fix it and raise the PR.

@z1R
Copy link

z1R commented Jul 17, 2024

identified the issue, will fix it and raise the PR.

Will this be implemented in the next update?

@THX723
Copy link

THX723 commented Jul 22, 2024

I would like to add this issue is also present in Safari (macOS).

@z1R
Copy link

z1R commented Nov 4, 2024

Has this been fixed?

@JamsRepos
Copy link

Has this been fixed?

Nope, still has massive subtitles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants