force-compilation? doesn't work.

[jjttjj]

Out of the box, in a fresh clojurescript repl, I get the following error:
(hipo/create [:div "a"] {:force-compilation? true})
Error: Failed to compile
Coming from this line of code: https://github.com/jeluard/hipo/blob/master/src/hipo/compiler.clj#L177

[jjttjj]

I think the problem is this line

hipo/src/hipo/core.clj

Line 21 in 1c10700

el# ~(if (:force-interpretation? m) `(hipo.interpreter/create ~v ~m) `(hc/compile-create ~v ~m))]

Specifically, in (hc/compile-create ~v ~m)), the unquoted v is a symbol and compile-create cannot handle a symbol.

This seems to be causing hipo to always use the interpreter.

I'll try to wrap my head more completely around the issue (is the outer let binding in create needed at all?) and submit a PR.

[jeluard]

Thanks for digging! Feel free to submit a PR!

…

Le 21 août 2018 à 17:38, Justin Tirrell ***@***.***> a écrit : I think the problem is this line https://github.com/jeluard/hipo/blob/1c107002bc5d338050046e9d8be2d8eba3fa9187/src/hipo/core.clj#L21 Specifically, in (hc/compile-create ~v ~m)), the unquoted v is a symbol and compile-create cannot handle a symbol. This seems to be causing hipo to always use the interpreter. I'll try to wrap my head more completely around the issue (is the outer let binding in create needed at all?) and submit a PR. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.