Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insomnia importer does not transfer environment variables #123

Closed
sswires opened this issue Oct 4, 2020 · 5 comments · Fixed by jenius-apps/nightingale-core#11
Closed
Labels
bug Something isn't working up for grabs Anyone can help work on this

Comments

@sswires
Copy link

sswires commented Oct 4, 2020

When importing a workspace export from Insomnia, it will import the individual requests with the correct verbs but it will not transfer the environment variables from the imported workspace. I have confirmed that the environment settings are in the exported JSON from Insomnia.

Steps to Reproduce:

  1. Install Insomnia
  2. Create a new workspace
  3. Configure two environments that set the same variable
  4. Use this variable as a part of a URL
  5. Export Workspace from the Import/Export menu item
  6. Attempt to import into Nightingale
  7. Acknowledge that environment variables are not imported, and variables used in URLs are not reflected

Expected Behaviour

Environment variables and variables used in URLs, queries and HTTP headers are correctly reflected after import.

@sswires sswires changed the title Insomnia importer does not transfer enviroment variables Insomnia importer does not transfer environment variables Oct 4, 2020
@dpaulino dpaulino added the bug Something isn't working label Oct 4, 2020
@dpaulino
Copy link
Contributor

I just open sourced Nightingale's insomnia converter code. If anyone wants to help fix this bug, I'd be extremely grateful! Here is the insomnia code: https://github.com/jenius-apps/nightingale-core/tree/master/src/Nightingale.Converters/Insomnia

@dpaulino dpaulino added the up for grabs Anyone can help work on this label Oct 18, 2020
@jamesmcroft
Copy link

Came to see if this issue existed and it does! I might see if I can work this out 👍

@dpaulino
Copy link
Contributor

dpaulino commented May 5, 2021

Should be available in v4.4. now. If someone can check and confirm that it's working, please let me know!

@jamesmcroft
Copy link

Appears to be importing Insomnia workspaces correctly now but I'm seeing a different issue. Some environment variables don't seem to be replaced when making a request.

I can dig into this a little further. Not sure if this is due to the import from Insomnia or something else.

@dpaulino
Copy link
Contributor

dpaulino commented May 7, 2021

If you have a repro steps can you make a new issue? I can investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working up for grabs Anyone can help work on this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants