Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing question mark on all POST requests #139

Closed
tipa opened this issue Nov 2, 2020 · 4 comments
Closed

Trailing question mark on all POST requests #139

tipa opened this issue Nov 2, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@tipa
Copy link

tipa commented Nov 2, 2020

It appears that a question mark ? is appended to all POST requests even though there are no parameters specified. This causes problems for some APIs, in my case this one: https://dev.fitbit.com/build/reference/web-api/oauth2/#retrieve-state-of-tokens
The endpoint returns

{
  "errors": [
    {
      "errorType": "not_found",
      "fieldName": "n/a",
      "message": "The API you are requesting could not be found."
    }
  ],
  "success": false
}

because of the trailing ?

@dpaulino dpaulino added the bug Something isn't working label Nov 2, 2020
@dpaulino
Copy link
Contributor

dpaulino commented Nov 2, 2020

Thanks for reporting this. I'll look into it asap

@dpaulino dpaulino added pending release Work completed. Will be available in a future release. and removed pending release Work completed. Will be available in a future release. labels Nov 4, 2020
@dpaulino
Copy link
Contributor

dpaulino commented Nov 4, 2020

@tipa fix should be available now. Can you try again?

@dpaulino
Copy link
Contributor

dpaulino commented Nov 5, 2020

It should be working now. Feel free to reopen if not!

@dpaulino dpaulino closed this as completed Nov 5, 2020
@tipa
Copy link
Author

tipa commented Nov 5, 2020

Thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants