Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode support for Gatsby site #185

Closed
krisstern opened this issue Nov 28, 2024 · 8 comments · Fixed by #189
Closed

Add dark mode support for Gatsby site #185

krisstern opened this issue Nov 28, 2024 · 8 comments · Fixed by #189
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@krisstern
Copy link
Member

What feature do you want to see added?

To add dark mode support to Gatsby site like what we have done for https://www.jenkins.io/.

Upstream changes

N/A

@krisstern krisstern added the enhancement New feature or request label Nov 28, 2024
@saurabhraghuvanshii
Copy link
Contributor

Hii @krisstern I can work on this .

@krisstern
Copy link
Member Author

Sure @saurabhraghuvanshii

@krisstern
Copy link
Member Author

Also, you may use the following merged PR's as references:

  1. Add dark mode: Add dark mode jenkins.io#7266
  2. Fix some elements in dark mode: Fix some elements in dark mode jenkins.io#7457
  3. Update back link icon in dark mode: Update back link icon in dark mode jenkins.io#7458
  4. Refresh the design of the 'Changelogs' pages: Refresh the design of the 'Changelogs' pages jenkins.io#7479

@saurabhraghuvanshii
Copy link
Contributor

@krisstern ok sir

@saurabhraghuvanshii
Copy link
Contributor

Hii @krisstern I have two question , that the changes where I have do is in docs.jenkins.io-gs/site .
Screenshot 2024-11-30 185737
And as I see that site is not responsive .

@krisstern
Copy link
Member Author

Hi @saurabhraghuvanshii yes, the changes you will need to do are to docs.jenkins.io-gs/site.

However, even if the site is not responsive, it should not affect your ability to implement dark mode or not, or does it? Hence I don't understand what you are asking.

@saurabhraghuvanshii
Copy link
Contributor

saurabhraghuvanshii commented Nov 30, 2024

@krisstern no It does not affect to implement dark mode , I just asking .

@krisstern krisstern added the help wanted Extra attention is needed label Nov 30, 2024
@krisstern
Copy link
Member Author

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants