Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: minimal hack to replace twitter log with X #3739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: minimal hack to replace twitter log with X #3739

wants to merge 1 commit into from
+8 −0

Conversation

msvticket
Copy link
Member

@msvticket msvticket commented Oct 8, 2024 •
edited
Loading

Description

Fixes jenkins-x/jx#8637

Checklist:

  • I have mentioned the appropriate type(scope), as referenced here in the commit message and PR title for the semantic checks to pass.
  • I have signed off the commit, as per instructions mentioned here.
  • Any dependent changes have already been merged.

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@msvticket
docs: minimal hack to replace twitter log with X
74b5028 
Fixes jenkins-x/jx#8673

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@msvticket
Copy link
Member Author

/retest

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3739 here

@msvticket
Copy link
Member Author

On the other hand a better fix would be to remove all references to twitter since nobody have access to the jenkins-x twitter account or are interested in taking care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Twitter Icon on Website
2 participants
@msvticket @jenkins-x-bot