Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All tests that touch script security approval are flakey #1444

Closed
timja opened this issue Dec 16, 2023 · 2 comments · Fixed by jenkinsci/script-security-plugin#549
Closed

All tests that touch script security approval are flakey #1444

timja opened this issue Dec 16, 2023 · 2 comments · Fixed by jenkinsci/script-security-plugin#549
Assignees
@jglick

Comments

@timja
Copy link
Member

timja commented Dec 16, 2023 •
edited
Loading

looks like a regression in the script security plugin

revert #1445 when fixed and any other recent suppressions
This was referenced Dec 16, 2023
Merged
Merged
@timja timja changed the title plugins.GroovyPluginTest#run_system_groovy_from_file and plugins.JobDslPluginTest#should_use_grooy_sandbox_no_whitelisted_content are failing All tests that touch script security approval are flakey Dec 17, 2023
@timja
Copy link
Member Author

timja commented Dec 17, 2023

cc @Vlatombe / @jglick likely cause is jenkinsci/script-security-plugin#545

@timja timja mentioned this issue Dec 17, 2023
Merged
@jglick jglick self-assigned this Dec 19, 2023
@jglick jglick mentioned this issue Dec 19, 2023
Merged
@jglick jglick mentioned this issue Jan 3, 2024
Merged
@timja timja reopened this Jan 3, 2024
@jglick
Copy link
Member

jglick commented Mar 4, 2024

Can this be closed @timja?

@timja timja closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jglick jglick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhauled ProxyWhitelist jglick/script-security-plugin
2 participants
@jglick @timja