Reduce code scanner warnings #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the method is only needed from a POST context, it should be annotated with @RequirePOST. The method does not invoke any risky code that might make it a security risk, but it is not useful as a GET method, so require that it must be called with POST.
The doXyz methods may be misinterpreted as Stapler methods. This is purely test code, but no reason to use poorly named methods in test code either.
MarkEWaite
added
the
chore
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce code scanner warnings
Annotate HTTP accessible method with RequirePOST. Since the method is only needed from a POST context, it should be annotated with @RequirePOST. The method does not invoke any risky code that might make it a security risk, but it is not useful as a GET method, so require that it must be called with POST.
Also renames several test methods to avoid warnings due to poorly named test methods.
Checklist
Types of changes