Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion : Container Level Validation #185

Closed
waveywaves opened this issue Nov 4, 2019 · 4 comments
Closed

Discussion : Container Level Validation #185

waveywaves opened this issue Nov 4, 2019 · 4 comments
Labels
question Further information is requested

Comments

@waveywaves
Copy link
Member

I noticed that a lot of validation was done on a container level which isn't the best way in an operator. As, admission controllers have the power to add containers / side-cars which augment the operator for specific purposes. In a scenario where a user deploys a service mesh in the cluster, and containers are added, the master pod validation will fail in the Jenkins Operator and keep restarting the pod.

@pawelprazak
Copy link

pawelprazak commented Nov 4, 2019

One solution would be to exclude jenkins namespace from the service mesh since it does not help the jenkins in any way. (that's what I've done in my clusters)

@pawelprazak pawelprazak added the question Further information is requested label Nov 4, 2019
@waveywaves
Copy link
Member Author

@pawelprazak In case of scenario when a user would like to use Jenkins with Service Mesh, to manage proxies and such, injecting sidecar containers becomes a norm. At such time the validation can break the operator.

@tomaszsek
Copy link

There are two solutions:

  1. Copy the whole sidecar container definition to the Jenkins CR.(@waveywaves Cloud you provide example yaml file?)
  2. Add mechanisms in operator which will skip validation for containers with name that will match particular regular expression.

@pawelprazak
Copy link

closing in favour of #197, #194, #199, #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants