Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken icons since Jenkins release 2.289.1 #7

Closed
livelace opened this issue Jun 8, 2021 · 9 comments
Closed

Broken icons since Jenkins release 2.289.1 #7

livelace opened this issue Jun 8, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@livelace
Copy link

livelace commented Jun 8, 2021

Versions

jenkins: 2.289.1
material plugin: 0.3.3
firefox: 88.0
chrome: 91.0.4472.77

Description

Broken icons (not animated) since Jenkins release 2.289.1 (pull 5065, pull 5392) . See pics.

build_history
projects
project

@livelace livelace added the bug Something isn't working label Jun 8, 2021
@timbrown5
Copy link
Contributor

I think the best way to fix this is to create a new version that stops adding custom icons for those which have been updated.

I think that will mean a new minor version (0.4), and backporting important fixes to (0.3.x).

This is likely going to be an ongoing battle with the UI changes that are planned.

@timbrown5
Copy link
Contributor

I have pushed a new version to master, are you able to double-check that it works for you?

@livelace
Copy link
Author

Yep, it works. Thanks.

blue
blue1

@NazarovNikita
Copy link

waiting for new release with fix, thx u

@timbrown5
Copy link
Contributor

Sorry, Jenkins-ci has changed the recommended release process and I got a bit stuck when I tried before.
Falling back to the older process seems to have worked.

@timbrown5
Copy link
Contributor

timbrown5 commented Jul 10, 2021

Last nights release uploaded to snapshots, so it's not available. I've been fighting on this morning and 0.4.1 is in the releases section:
https://repo.jenkins-ci.org/releases/io/jenkins/plugins/material-theme/0.4.1/
It should hopefully be available in the next few hours (although I've seen a number of intermittent issues with the https://repo.jenkins-ci.org/public/ this week so we shall have to wait and see).

Here is an example of the errors we've been seeing - unrelated to this bug, just mentioning in case you see something similar when fetching the update.

10:56:02 [ERROR] Failed to execute goal on project material-theme: Could not resolve dependencies for project io.jenkins.plugins:material-theme:hpi:0.4.2-SNAPSHOT: Could not transfer artifact org.jenkins-ci.main:jenkins-core:jar:2.289.1 from/to repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/): GET request of: org/jenkins-ci/main/jenkins-core/2.289.1/jenkins-core-2.289.1.jar from repo.jenkins-ci.org failed: Premature end of Content-Length delimited message body (expected: 11,146,641; received: 382,707) -> [Help 1]

Ref: https://ci.jenkins.io/job/Plugins/job/material-theme-plugin/job/master/31/console

@timbrown5
Copy link
Contributor

There is an outage on update center
https://groups.google.com/g/jenkinsci-dev/c/vZWsHBCYOyM
I hope when this is resolved the 0.4.1 release of plugin will be available.

@timbrown5
Copy link
Contributor

Seems like the release is now live.
Screenshot 2021-07-12 at 10 44 46
Note: this is marked as not available as the Jenkins instance this screenshot is from is using 2.277.4 and this needs >=2.289.1.

@NazarovNikita
Copy link

NazarovNikita commented Jul 12, 2021

image


everything looks and works great.
Thank you so much

jenkins 2.289.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants