Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename maven-hpi-plugin to hpi-maven-plugin #510

Open
basil opened this issue Jun 30, 2023 · 1 comment
Open

Rename maven-hpi-plugin to hpi-maven-plugin #510

basil opened this issue Jun 30, 2023 · 1 comment

Comments

@basil
Copy link
Member

basil commented Jun 30, 2023

Our Maven build contains the following warning:

Artifact IDs of the format maven-___-plugin are reserved for plugins in the group ID org.apache.maven.plugins. Please change your artifact ID to the format ___-maven-plugin. In the future this error will break the build.

This notice elaborates further:

Calling it maven-<yourplugin>-plugin (note "Maven" is at the beginning of the plugin name) is strongly discouraged since it's a reserved naming pattern for official Apache Maven plugins maintained by the Apache Maven team with group ID org.apache.maven.plugins. Using this naming pattern is an infringement of the Apache Maven Trademark.

Renaming this plugin is trivial, but the real work in this task is adapting all consumers to the new name. In addition the hpi-plugin.version property in the core and plugin parent POMs should be renamed to hpi-maven-plugin.version. PCT consumes this, among other things.


Reference: https://maven.apache.org/guides/plugin/guide-java-plugin-development.html

@basil
Copy link
Member Author

basil commented Jul 27, 2023

Since this change is large and fairly disruptive, it may be worth considering tackling the rename from HPI to JPI as part of this as well:

  • jpi-maven-plugin
  • Switching packaging from hpi to jpi
  • Switching default file extension from hpi to jpi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant