Skip to content

Commit 26fe7b0

Browse files
committed
Suppress false-positive security warnings
1 parent 03b80aa commit 26fe7b0

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/main/java/com/github/farmgeek4life/jenkins/negotiatesso/NegotiateSSO.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -452,10 +452,15 @@ public ListBoxModel doFillProtocolsItems() {
452452
}
453453

454454
/**
455-
* Used by groovy for data-binding.
456-
*
455+
* Used by groovy for data-binding: provides a name and java classpath for an HTML 'select' element
456+
*
457+
* Suppressed warnings (for security scans):
458+
* * permission check: the configuration page is restricted to 'ADMINISTER' permissions, but this function is only providing the potential choices, not changing settings
459+
* * csrf: We do not provide routable URLs, only a text name (with spaces) and a java classpath reference for internal use
460+
*
457461
* @return the allowed provider strings
458462
*/
463+
@SuppressWarnings({"lgtm[jenkins/no-permission-check]", "lgtm[jenkins/csrf]"})
459464
public ListBoxModel doFillProvidersItems() {
460465
ListBoxModel items = new ListBoxModel();
461466
items.add("Negotiate, then Basic", NegotiateSecurityFilterProvider.class.getName() + " " + BasicSecurityFilterProvider.class.getName());

0 commit comments

Comments
 (0)