Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardising env vars TRACEPARENT and TRACESTATE in OTel specification #156

Closed
aidansteele opened this issue Aug 24, 2021 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@aidansteele
Copy link

I was told about this project yesterday and I am very excited by the work you are doing.

Have you considered "upstreaming" your usage of TRACEPARENT and TRACESTATE environment variables to the OpenTelemetry specification? I feel that it would be a valuable addition to the spec. There was an issue opened about a year ago regarding env vars as carriers but it hasn't since progressed: open-telemetry/opentelemetry-specification#740.

I feel it would be valuable because there are a few different solutions currently out there and they are generally vendor-specific. E.g.

Right now there are very few general-purpose tools that emit distributed tracing data and I expect it's because there is no standard. It could be exceedingly useful to have unit test frameworks emit spans for test suites, have infrastructure-as-code tools (e.g. Terraform, CDK) emit spans for resource creation, have integration tests propagate spans to systems under test, etc. And it feels that this plugin's choice of env vars has the best chance of being generally useful and achieving this goal.

What are your thoughts? I imagine that @v1v and/or @cyrille-leclerc both have more experience in the OTel space than I do personally. I would be happy to attempt to submit an OTEP for this idea, but I imagine that either of you might have a better idea of how to do so successfully.

@cyrille-leclerc
Copy link
Contributor

cyrille-leclerc commented Aug 24, 2021

You are right @aidansteele that we have enough maturity to propagate the trace context between CI platforms and build tools using TRACEPARENT and TRACESTATE to propose a standardisation.

I added a comment to open-telemetry/opentelemetry-specification#740 (comment)
I'll have bandwidth next week to engage with the Otel community on this OTEP.

cc @tobert , @v1v, @kuisathaverat

@cyrille-leclerc cyrille-leclerc changed the title Standardising env vars "upstream" in OTel specification Standardising env vars TRACEPARENT and TRACESTATE in OTel specification Sep 6, 2021
@cyrille-leclerc cyrille-leclerc added the enhancement New feature or request label Sep 6, 2021
@kuisathaverat
Copy link
Contributor

The plugin enables propagation of TRACEPARENTand TRACESTATE, all the matters about OpenTelemetry specification are managed at open-telemetry/opentelemetry-specification#740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants