Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IssueCommentTrigger is not working for few users having collaborator access #131

Open
preetam810 opened this issue Sep 14, 2024 · 1 comment
Labels

Comments

@preetam810
Copy link

preetam810 commented Sep 14, 2024

Jenkins and plugins versions report

Environment
Plugin Version: 2.8-159.09e4403bc62f

What Operating System are you using (both controller, and any agents involved in the problem)?

Amazon Linux 2

Reproduction steps

I'm using GitHub app for authentication and have set the permissions required to use IssueCommentTrigger in my pipelines. I'm the org owner on GitHub having admin permissions. Before releasing my pipeline I tested it with myself and a couple of users who were collaborators with write permission and it worked well. All users are part of different GitHub teams. After the release of my pipeline many users in my org now use the pipeline without problems. However, some users reported that they are not able to trigger the build using a pull request comment. These users are actually authors of their pull request having write permission on repository. I also checked and confirmed by the response of the API call to check collaborator status: https://docs.github.com/en/rest/collaborators/collaborators?apiVersion=2022-11-28#check-if-a-user-is-a-repository-collaboratory
I'm not able to debug why this is happening only for a handful users who are actually collaborators. It would be really helpful if you have any suggestions on investigating this further.

Expected Results

IssueCommentTrigger works for all collaborators.

Actual Results

Few users reported that IssueCommentTrigger is not working even after having collaborators access.

Anything else?

No response

Are you interested in contributing a fix?

No response

@preetam810 preetam810 added the bug label Sep 14, 2024
@xocasdashdash
Copy link

hey!
So one thing you can try is add a bit of logging on the plugin, open a PR and i believe the building process generates a plugin binary (see here as an example)

If you tested the curl request directly and it's failing. I'd think the issue is with the github config and that you open a support ticket with them to understand what's going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants