Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ensure parameter to jenkins::slave #150

Merged
merged 1 commit into from
Sep 22, 2014

Conversation

carlossg
Copy link
Member

Allows running the slave manually instead of a service, useful in Docker for instance

@rtyler
Copy link

rtyler commented Jul 16, 2014

@carlossg could I convince you to add an rspec-puppet example or two to verify that passing a class parameter into the jenkins::slave class gets to the service correctly?

@carlossg
Copy link
Member Author

Added. The travis build is broken from the previous commit.
You may consider switching rcov to simplecov. rcov doesn't work in 1.9 and it's a native gem that needs to be compiled https://github.com/relevance/rcov

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@carlossg
Copy link
Member Author

do you need anything else?

@carlossg
Copy link
Member Author

rebased

@justinclayton
Copy link

it's failing presumably only because of the pending test?

@carlossg
Copy link
Member Author

puppet-lint error. Previous builds used puppet-lint 0.3.2, this one used 1.0.1

The command "rake lint" exited with 1.

@carlossg
Copy link
Member Author

lint issues fixed in #167

Allows running the slave manually instead of a service, useful in Docker for instance
@rtyler rtyler added this to the 1.2.0: Nestor milestone Sep 22, 2014
rtyler pushed a commit that referenced this pull request Sep 22, 2014
Add ensure parameter to jenkins::slave
@rtyler rtyler merged commit 5675931 into voxpupuli:master Sep 22, 2014
@carlossg carlossg deleted the slave-ensure branch September 22, 2014 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants