A bit of RedHat and Debian slave initd script merging #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Thank you for adding this. Hopefully this fix is suitable for merge. |
|
It looks like this can't be merged automatically. I'll try to rework this pull request and resolve the conflicts |
Add -mode flag to Debian slave start script Use a single /etc/defaults or /etc/sysconfig file for both OSes Do not customize /etc/init.d/jenkins-slave, do it in sysconfig or defaults Log output to file in RedHat Compose slave arguments in shell script
carlossg
force-pushed
the
slave-initd
branch
from
13da477
to
a22888f
Compare
|
I have rebased against master |
|
@carlossg If you're at PuppetConf we can hack on this together? :) |
|
@rtyler unfortunately not this year, but hanging on irc |
|
I'm going to fix some of the lint warnings after merging |
rtyler
pushed a commit
that referenced
this pull request
Sep 22, 2014
A bit of RedHat and Debian slave initd script merging
This was referenced Sep 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid duplication and mismatches between Debian and RedHat, use initd scripts, both configured with a common
/etc/defaults/jenkins-slavein Debian and/etc/sysconfig/jenkins-slavein RedHatAdd -mode flag to Debian slave start script
Use a single /etc/defaults or /etc/sysconfig file for both OSes
Do not customize /etc/init.d/jenkins-slave, do it in sysconfig or defaults
Log output to file in RedHat
Compose slave arguments in shell script