add user/group mgt. + localstatedir params to jenkins class #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have prefer to split this into to separate PRs but the user management change is tightly coupled to directory management. |
jhoblitt
force-pushed
the
feature/centralize-user-and--dir-config
branch
from
740ceba
to
638f198
Compare
|
Looks like this should resolve #362 as well. |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
jhoblitt
force-pushed
the
feature/centralize-user-and--dir-config
branch
from
638f198
to
4ad84d1
Compare
jhoblitt
force-pushed
the
feature/centralize-user-and--dir-config
branch
from
4ad84d1
to
2fb931f
Compare
* add `manager_user`, `user`, `manage_group`, `group` params to `jenkins` class. * improve consistency of `file` resouce group ownership throughout the module * add 'localstatedir' param to `jenkins` class and consistently use it to set the 'data' base dir throughout the module * Deprecate/noop `username`, `group`, `create_user` params to `jenkins::plugin` define; replaced by `user`,`group`,etc. params to `jenkins` class * Deprecate/noop `plugin_dir` param to `jenkins::plugin`; replaced by `localstatedir` param to `jenkins` class closes voxpupuli#356 -- alternative approach resolves voxpupuli#362 resolves voxpupuli#365 resolves voxpupuli#219 resolves voxpupuli#249 resolves voxpupuli#250
jhoblitt
force-pushed
the
feature/centralize-user-and--dir-config
branch
from
2fb931f
to
f5b5f40
Compare
|
Nah, let's move fast and break things! 👍 |
rtyler
pushed a commit
that referenced
this pull request
Oct 12, 2015
…r-config add user/group mgt. + localstatedir params to jenkins class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manager_user,user,manage_group,groupparams tojenkinsclass.fileresouce group ownership throughoutthe module
jenkinsclass and consistently use itto set the 'data' base dir throughout the module
username,group,create_userparams tojenkins::plugindefine; replaced byuser,group,etc. params tojenkinsclassplugin_dirparam tojenkins::plugin; replaced bylocalstatedirparam tojenkinsclasscloses #356 -- alternative approach
resolves #362
resolves #365
resolves #219
resolves #249
resolves #250