client_url is hardcoded in slave.pp #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2015 08:33
| @@ -93,12 +93,13 @@ | |||
| $install_java = $jenkins::params::install_java, | |||
| $ensure = 'running', | |||
| $enable = true | |||
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@zonArt Could you squash these commits down and give us a headsup when you feel this PR is ready? |
|
@jhoblitt IMHO squashing commits isn't necessary, it's often nice but meh |
rtyler
pushed a commit
that referenced
this pull request
Oct 13, 2015
…_to_get_swarm_plugin_from_a_custom_location client_url is hardcoded in slave.pp
zonArt
deleted the
feature/Giving_the_possibility_to_get_swarm_plugin_from_a_custom_location
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to give the possibility to change it