Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect drive letter substitution on Windows #17

Closed
climblinne opened this issue Jun 22, 2018 · 1 comment
Closed

Incorrect drive letter substitution on Windows #17

climblinne opened this issue Jun 22, 2018 · 1 comment

Comments

@climblinne
Copy link

When using another drive on Windows D: or even c: the plugin is not working correct.

Please replace in WithPythonEnvStep.java (line 73)

 String postfix = pythonInstallation.replaceAll("/", "-")
                .replaceFirst("C:\\\\", "")
                .replaceAll("\\\\", "-");

with

 String postfix = pythonInstallation.replaceAll("/", "-")
                .replaceFirst("[a-zA-Z]:\\\\", "")
                .replaceAll("\\\\", "-");
@cstarner
Copy link

Thank you for bringing this to my attention. I've fixed it and am closing this issue.

Always feel free to submit a pull request, especially for small stuff like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants