Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a figure, going back to the catalog tab, and then clicking the same figure doesn't do anything #15

Open
daattali opened this issue Feb 18, 2016 · 5 comments

Comments

@daattali
Copy link
Collaborator

If you try to click on a figure that's already the last viewed figure, nothing happens (you don't get automatically moved to the figure tab)

@jennybc
Copy link
Owner

jennybc commented Feb 18, 2016

😥

@jennybc
Copy link
Owner

jennybc commented Feb 18, 2016

Do you know how to fix that?

@daattali
Copy link
Collaborator Author

I'm pretty sure this is the cause

There's no super duper clean fix for it, but it can done.... semi-hackily...

It's not very high pri, is it? I don't want to deal with that right now, remind me in a month if you still care about it

@jennybc
Copy link
Owner

jennybc commented Feb 18, 2016

Well I guess it can wait. You can always go from fig x to catalog to fig x by visiting fig y somewhere along the way.

Is this a sign we should do this the other way you mentioned? Via the URL?

@daattali
Copy link
Collaborator Author

Not really. The only way you could use the URL to fix this is if clicking on each image actually went to a new URL. But that would mean that every click on an image would cause the entire app to re-load, which isn't nice. The way the URL thing works right now is that we just add some text to the URL, but there is no page reload. I'm not sure if that makes sense? It's just a common problem shiny apps that use javascript actions face, it's not indicative of a poor app design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants