Allow scheme and host to be configured application wide (#66)

beam-community · Jul 12, 2017 · 1bbe4de · 1bbe4de
1 parent 42a4454
commit 1bbe4de
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/jsonapi/view.ex b/lib/jsonapi/view.ex
@@ -117,11 +117,11 @@ defmodule JSONAPI.View do
       end
 
       def url_for(data, %Plug.Conn{}=conn) when is_list(data) do
-        "#{Atom.to_string(conn.scheme)}://#{conn.host}#{@namespace}/#{type()}"
+        "#{scheme(conn)}://#{host(conn)}#{@namespace}/#{type()}"
       end
 
       def url_for(data, %Plug.Conn{}=conn) do
-        "#{Atom.to_string(conn.scheme)}://#{conn.host}#{@namespace}/#{type()}/#{id(data)}"
+        "#{scheme(conn)}://#{host(conn)}#{@namespace}/#{type()}/#{id(data)}"
       end
 
       def url_for_rel(data, rel_type, conn) do
@@ -155,6 +155,10 @@ defmodule JSONAPI.View do
         |> String.to_atom
       end
 
+      defp host(conn), do: Application.get_env(:jsonapi, :host, conn.host)
+
+      defp scheme(conn), do: Application.get_env(:jsonapi, :scheme, to_string(conn.scheme))
+
       defoverridable attributes: 2,
                      fields: 0,
                      id: 1,

diff --git a/test/jsonapi/view_test.exs b/test/jsonapi/view_test.exs
@@ -33,14 +33,26 @@ defmodule JSONAPI.ViewTest do
     assert PostView.type == "posts"
   end
 
-  test "url_for/2 with namespace" do
+  test "url_for/2" do
     assert PostView.url_for(nil, nil) == "/api/posts"
     assert PostView.url_for([], nil) == "/api/posts"
     assert PostView.url_for(%{id: 1}, nil) == "/api/posts/1"
     assert PostView.url_for([], %Plug.Conn{}) == "http://www.example.com/api/posts"
     assert PostView.url_for(%{id: 1}, %Plug.Conn{}) == "http://www.example.com/api/posts/1"
     assert PostView.url_for_rel([], "comments", %Plug.Conn{}) == "http://www.example.com/api/posts/relationships/comments"
     assert PostView.url_for_rel(%{id: 1}, "comments", %Plug.Conn{}) == "http://www.example.com/api/posts/1/relationships/comments"
+
+    Application.put_env(:jsonapi, :host, "www.otherhost.com")
+    assert PostView.url_for([], %Plug.Conn{}) == "http://www.otherhost.com/api/posts"
+    assert PostView.url_for(%{id: 1}, %Plug.Conn{}) == "http://www.otherhost.com/api/posts/1"
+    assert PostView.url_for_rel([], "comments", %Plug.Conn{}) == "http://www.otherhost.com/api/posts/relationships/comments"
+    assert PostView.url_for_rel(%{id: 1}, "comments", %Plug.Conn{}) == "http://www.otherhost.com/api/posts/1/relationships/comments"
+
+    Application.put_env(:jsonapi, :scheme, "ftp")
+    assert PostView.url_for([], %Plug.Conn{}) == "ftp://www.otherhost.com/api/posts"
+    assert PostView.url_for(%{id: 1}, %Plug.Conn{}) == "ftp://www.otherhost.com/api/posts/1"
+    assert PostView.url_for_rel([], "comments", %Plug.Conn{}) == "ftp://www.otherhost.com/api/posts/relationships/comments"
+    assert PostView.url_for_rel(%{id: 1}, "comments", %Plug.Conn{}) == "ftp://www.otherhost.com/api/posts/1/relationships/comments"
   end
 
   @tag :compile_phoenix