Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Content-Type for Errors #144

Merged

Conversation

jherdman
Copy link
Contributor

Prior to this change errors lacked this content type. This may confuse
some consumers of the API.

@jherdman jherdman force-pushed the errors-have-correct-content-type branch from b665b4f to 2985437 Compare December 12, 2018 18:16
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

test/jsonapi/plugs/content_type_negotiation_test.exs Outdated Show resolved Hide resolved
Prior to this change errors lacked this content type. This may confuse
some consumers of the API
@jherdman jherdman force-pushed the errors-have-correct-content-type branch from 2985437 to 97ea566 Compare December 12, 2018 20:53
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful addition! 💯

@doomspork doomspork merged commit 2d0dec2 into beam-community:master Dec 19, 2018
@jherdman jherdman deleted the errors-have-correct-content-type branch January 8, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants