-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FloatingComponent prop #162
Add FloatingComponent prop #162
Conversation
For some reason, I couldn't embed it directly to github, added a imgur GIF link. Here's the original video recorded: https://imgur.com/a/w8CNEgw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it looks good and I'm totally good with the introduction of this props.
Even though I'm kinda asking changes that will make you remove the examples you did and change the props name. Sorry about that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed everything to my branch, @jeremybarbet can you take a look again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes and we are good to merge! Thanks
Co-Authored-By: Jérémy Barbet <jeremgraph@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good?
Sweet, it looks good! Thank you for quick response to that! |
Hey!
I added the new prop, updated Props Docs, Readme preview, types and examples. Also merged with latest changes from rc15. (Tested examples with react-navigation and rn-native-navigation, couldn't run expo example but I'm certain it should work)
Here's the original recorded preview:
https://imgur.com/a/w8CNEgw
in case the gif below is not OK