Add FloatingComponent prop #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, I couldn't embed it directly to github, added a imgur GIF link. Here's the original video recorded: https://imgur.com/a/w8CNEgw
jeremybarbet
requested changes
Mar 28, 2020
vforvasile
commented
Mar 29, 2020
There was a problem hiding this comment.
I pushed everything to my branch, @jeremybarbet can you take a look again?
jeremybarbet
requested changes
Mar 29, 2020
Co-Authored-By: Jérémy Barbet <jeremgraph@gmail.com>
|
Sweet, it looks good! Thank you for quick response to that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I added the new prop, updated Props Docs, Readme preview, types and examples. Also merged with latest changes from rc15. (Tested examples with react-navigation and rn-native-navigation, couldn't run expo example but I'm certain it should work)
Here's the original recorded preview:
https://imgur.com/a/w8CNEgw
in case the gif below is not OK