Dynamic change param "adjustToContentHeight" is not working

[SmirnovM91]

If I set adjustToContentHeight = true once,
then If I try to set adjustToContentHeight = false
It still adjustToContentHeight = true

is it ok? or bug?

[jeremybarbet]

Hi!

This is not an issue. The adjustToContentHeight is initialized when the component is mounted for the first time. Which mean even when you change the props, the calculation is not run again.

We would need to introduce a listener on the component to run the functions needed, feel free to open a PR to add this

[vforvasile]

Hey @jeremybarbet!

Amazing job with the library, found out about it on reddit and switched from react-native-reanimated-bottom-sheet right away.

Any ETA on dynamic height feature?

On a separate issue, is there any method of overlaying something on the Modalize with an absolute position that won't move on scroll? Header/footer components don't really do the job for me, they're scroll dependant.

[jeremybarbet]

Hi @vforvasile, thank you for using Modalize.

No, I don't have any ETA. I'm trying to work on it when I have a bit of time, but I'm quite busy. If you have any idea how to fix this, I would be happy to review your PR!

You can use position absolute on the Header/Footer components so they will be on top of the scrollview, and will stay fixed. You have an example here: https://github.com/jeremybarbet/react-native-modalize/blob/master/examples/expo/src/components/modals/AbsoluteHeader.js#L9-L24

[vforvasile]

@jeremybarbet , I tried this approach, it works well if you open Modalize at full height, if you have a snap point then the FlatList will move with the absolute element.

I tested with a new prop childOverlay in renderModalize(), by setting zIndex over 100 and absolute styling (bottom:0) to childOverlay I'm passing

Now it works even if I scroll up/down, move from snap point to full mode

[jeremybarbet]

Would you mind creating a PR to introduce this new props?

[vforvasile]

on it!

[jeremybarbet]

Now able to toggle the prop and re-calculate the height https://b.ueno.is/p9uK9P5d Fixed in rc-17.