Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing domain with ip prefix will not work #347

Closed
joe820912boy opened this issue Feb 6, 2023 · 3 comments
Closed

Parsing domain with ip prefix will not work #347

joe820912boy opened this issue Feb 6, 2023 · 3 comments
Assignees

Comments

@joe820912boy
Copy link

joe820912boy commented Feb 6, 2023

I found that some domain with ip prefix that the parser wouldn't work on it.

Like '1.1.1.1.cloudflare-dns.com' , the public suffix and top level domains just return nothing.

Does the parser not support this format, or is there anything I didn't notice it?

@nyamsprod nyamsprod self-assigned this Feb 7, 2023
@joe820912boy joe820912boy changed the title Parsing ip with domain will not work Parsing domain with ip prefix will not work Feb 8, 2023
@nyamsprod
Copy link
Collaborator

@joe820912boy a PR has landed with a fix to this issue you can check, review and download it to see if all is fixed see #348

@joe820912boy
Copy link
Author

joe820912boy commented Feb 21, 2023

@nyamsprod thanks for bug fixed for some special format domain

and it seems that this fix didn't release for the current version?

I run composer update it didn't update anything,

or should I manually edit the code?

@joe820912boy
Copy link
Author

I have solved the problem by re-install the dev version.

composer require jeremykendall/php-domain-parser:develop-dev

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants