Need to load ICU data file on Fedora

[jeroen]

Looks like Fedora 30 version of libv8 now also has a custom ICU so we to do something similar:

V8/src/bindings.cpp

Lines 36 to 40 in 6ac6e34

	#ifdef V8_ICU_DATA_PATH
	// Needed if V8 is built with bundled ICU. Check CRAN package 'dagitty' to test.
	if( access( V8_ICU_DATA_PATH, F_OK ) != -1 ) {
	v8::V8::InitializeICUDefaultLocation(V8_ICU_DATA_PATH);
	}

Bug report in dagitty: jtextor/dagitty#24

[jtextor]

Minimal code example to make V8 crash in R on Fedora 30 without dagitty or other libraries:

V8::new_context()$eval("\"a\".localeCompare(\"b\")")

The same code works for me in nodejs on the same machine:

[root@fedora-2gb-nbg1-1 ~]# node
> "a".localeCompare("b")
-1
> 

[jeroen]

Thanks that is very helpful!

[jeroen]

Here is the bug report in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1755114

[jeroen]

Still a problem if we build against v8-devel in Fedora 34 (but not with DOWNLOAD_STATIC_LIBV8).