Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new Floating action button theme #71

Open
2 tasks
jeroen1602 opened this issue Sep 30, 2020 · 1 comment
Open
2 tasks

Implement new Floating action button theme #71

jeroen1602 opened this issue Sep 30, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jeroen1602
Copy link
Owner

The floating action button theme has been deprecated and should be replaced with FloatingActionButtonThemeData. As described in this document. (The document has been grieved a lot so make sure to select viewing mode in the top right.)

  • Implement FAB theme for light mode
  • Implement FAB theme for dark mode
@jeroen1602 jeroen1602 added the enhancement New feature or request label Sep 30, 2020
@jeroen1602 jeroen1602 modified the milestones: v1.1.1, v1.1.2 Oct 1, 2020
@jeroen1602
Copy link
Owner Author

When changing themes the flutter library throws a warning in the console.
Warning: The support for configuring the foreground color of FloatingActionButtons using ThemeData.accentIconTheme has been deprecated. Please use ThemeData.floatingActionButtonTheme instead. See https://flutter.dev/go/remove-fab-accent-theme-dependency. This feature was deprecated after v1.13.2.

But while looking into it, the app doesn't change the foreground color of the FloatingActionButtons that are in the app. So we'll have to see when it crashes in future versions, if it crashes.

@jeroen1602 jeroen1602 removed this from the v1.1.3 milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeroen1602