Move 'nums_with_ascending_length' to be a global, non variable length array.

VLAs cannot be initialized by any form of initialization syntax with C99 standard.
Also did some refactor around 'ecma_string_get_length' and 'ecma_string_get_size'.

VLAs cannot be initialized by any form of initialization syntax with C99 standard.

JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com

Author: robertsipka

jerry-core/ecma/base/ecma-helpers-string.cpp

@@ -1285,6 +1285,42 @@ ecma_compare_ecma_strings_relational (const ecma_string_t *string1_p, /**< ecma-
   return is_first_less_than_second;
 } /* ecma_compare_ecma_strings_relational */
 
+/**
+ * Lengths for numeric string values
+ */
+const uint32_t nums_with_ascending_length[] =
+{
+  1u,
+  10u,
+  100u,
+  1000u,
+  10000u,
+  100000u,
+  1000000u,
+  10000000u,
+  100000000u,
+  1000000000u
+};
+
+/**
+ * Maximum length of numeric strings
+ */
+const uint32_t max_uint32_len = sizeof (nums_with_ascending_length) / sizeof (uint32_t);
+
+/**
+ * Get size of container heap number of ecma-string
+ *
+ * @return number of bytes in the buffer
+ */
+static lit_utf8_size_t
+ecma_string_get_heap_number_size (mem_cpointer_t number_cp) /**< ecma-string */
+{
+  const ecma_number_t *num_p = ECMA_GET_NON_NULL_POINTER (ecma_number_t, number_cp);
+  lit_utf8_byte_t buffer[ECMA_MAX_CHARS_IN_STRINGIFIED_NUMBER];
+
+  return ecma_number_to_utf8_string (*num_p, buffer, sizeof (buffer));
+} /* ecma_string_get_heap_number_size */
+
 /**
  * Get length of ecma-string
  *
@@ -1293,75 +1329,55 @@ ecma_compare_ecma_strings_relational (const ecma_string_t *string1_p, /**< ecma-
 ecma_length_t
 ecma_string_get_length (const ecma_string_t *string_p) /**< ecma-string */
 {
-  ecma_string_container_t container = (ecma_string_container_t) string_p->container;
-
-  if (container == ECMA_STRING_CONTAINER_LIT_TABLE)
-  {
-    lit_literal_t lit = lit_get_literal_by_cp (string_p->u.lit_cp);
-    JERRY_ASSERT (RCS_RECORD_IS_CHARSET (lit));
-    return lit_charset_literal_get_length (lit);
-  }
-  else if (container == ECMA_STRING_CONTAINER_MAGIC_STRING)
-  {
-    TODO ("Cache magic string lengths")
-    return lit_utf8_string_length (lit_get_magic_string_utf8 (string_p->u.magic_string_id),
-                                   lit_get_magic_string_size (string_p->u.magic_string_id));
-  }
-  else if (container == ECMA_STRING_CONTAINER_MAGIC_STRING_EX)
-  {
-    TODO ("Cache magic string lengths")
-    return lit_utf8_string_length (lit_get_magic_string_ex_utf8 (string_p->u.magic_string_ex_id),
-                                   lit_get_magic_string_ex_size (string_p->u.magic_string_ex_id));
-  }
-  else if (container == ECMA_STRING_CONTAINER_UINT32_IN_DESC)
+  switch ((ecma_string_container_t) string_p->container)
   {
-    const uint32_t uint32_number = string_p->u.uint32_number;
-    const uint32_t max_uint32_len = 10;
-    const uint32_t nums_with_ascending_length[10] =
+    case ECMA_STRING_CONTAINER_LIT_TABLE:
     {
-      1u,
-      10u,
-      100u,
-      1000u,
-      10000u,
-      100000u,
-      1000000u,
-      10000000u,
-      100000000u,
-      1000000000u
-    };
-
-    ecma_length_t length = 1;
-
-    while (length < max_uint32_len
-           && uint32_number >= nums_with_ascending_length[length])
+      lit_literal_t lit = lit_get_literal_by_cp (string_p->u.lit_cp);
+      JERRY_ASSERT (RCS_RECORD_IS_CHARSET (lit));
+      return lit_charset_literal_get_length (lit);
+    }
+    case ECMA_STRING_CONTAINER_MAGIC_STRING:
     {
-      length++;
+      TODO ("Cache magic string lengths")
+      return lit_utf8_string_length (lit_get_magic_string_utf8 (string_p->u.magic_string_id),
+                                     lit_get_magic_string_size (string_p->u.magic_string_id));
     }
+    case ECMA_STRING_CONTAINER_MAGIC_STRING_EX:
+    {
+      TODO ("Cache magic string lengths")
+      return lit_utf8_string_length (lit_get_magic_string_ex_utf8 (string_p->u.magic_string_ex_id),
+                                     lit_get_magic_string_ex_size (string_p->u.magic_string_ex_id));
+    }
+    case ECMA_STRING_CONTAINER_UINT32_IN_DESC:
+    {
+      const uint32_t uint32_number = string_p->u.uint32_number;
+      ecma_length_t length = 1;
 
-    return length;
-  }
-  else if (container == ECMA_STRING_CONTAINER_HEAP_NUMBER)
-  {
-    const ecma_number_t *num_p = ECMA_GET_NON_NULL_POINTER (ecma_number_t,
-                                                            string_p->u.number_cp);
-
-    lit_utf8_byte_t buffer[ECMA_MAX_CHARS_IN_STRINGIFIED_NUMBER];
+      while (length < max_uint32_len
+             && uint32_number >= nums_with_ascending_length[length])
+      {
+        length++;
+      }
 
-    return (ecma_length_t) ecma_number_to_utf8_string (*num_p, buffer, sizeof (buffer));
-  }
-  else
-  {
-    JERRY_ASSERT (container == ECMA_STRING_CONTAINER_HEAP_CHUNKS);
+      return length;
+    }
+    case ECMA_STRING_CONTAINER_HEAP_NUMBER:
+    {
+      return (ecma_length_t) ecma_string_get_heap_number_size (string_p->u.number_cp);
+    }
+    default:
+    {
+      JERRY_ASSERT ((ecma_string_container_t) string_p->container == ECMA_STRING_CONTAINER_HEAP_CHUNKS);
 
-    const ecma_collection_header_t *collection_header_p = ECMA_GET_NON_NULL_POINTER (ecma_collection_header_t,
-                                                                                     string_p->u.collection_cp);
+      const ecma_collection_header_t *collection_header_p = ECMA_GET_NON_NULL_POINTER (ecma_collection_header_t,
+                                                                                       string_p->u.collection_cp);
 
-    return ecma_get_chars_collection_length (collection_header_p);
+      return ecma_get_chars_collection_length (collection_header_p);
+    }
   }
 } /* ecma_string_get_length */
 
-
 /**
  * Get size of ecma-string
  *
@@ -1390,22 +1406,8 @@ ecma_string_get_size (const ecma_string_t *string_p) /**< ecma-string */
     case ECMA_STRING_CONTAINER_UINT32_IN_DESC:
     {
       const uint32_t uint32_number = string_p->u.uint32_number;
-      const int32_t max_uint32_len = 10;
-      const uint32_t nums_with_ascending_length[max_uint32_len] =
-      {
-        1u,
-        10u,
-        100u,
-        1000u,
-        10000u,
-        100000u,
-        1000000u,
-        10000000u,
-        100000000u,
-        1000000000u
-      };
-
-      int32_t size = 1;
+
+      uint32_t size = 1;
       while (size < max_uint32_len
               && uint32_number >= nums_with_ascending_length[size])
       {
@@ -1415,13 +1417,7 @@ ecma_string_get_size (const ecma_string_t *string_p) /**< ecma-string */
     }
     case ECMA_STRING_CONTAINER_HEAP_NUMBER:
     {
-      const ecma_number_t *num_p = ECMA_GET_NON_NULL_POINTER (ecma_number_t,
-                                                            string_p->u.number_cp);
-      lit_utf8_byte_t buffer[ECMA_MAX_CHARS_IN_STRINGIFIED_NUMBER];
-
-      return ecma_number_to_utf8_string (*num_p,
-                buffer,
-                sizeof (buffer));
+      return ecma_string_get_heap_number_size (string_p->u.number_cp);
     }
     default:
     {