Skip to content

Commit 3828f08

Browse files
committed
Remove arbitrary case conversion tests.
Since upper/lower case conversions are unspecified by the standard, we convert ASCII characters only, and a few other characters for testing purposes. Because these are just random cases, it is better to remove them before the release. At some point we could add a unicode compatible case conversion which can be enabled at compile time. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
1 parent 6084f08 commit 3828f08

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

jerry-core/lit/lit-char-helpers.c

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -482,13 +482,6 @@ lit_char_to_lower_case (ecma_char_t character, /**< input character value */
482482
return 1;
483483
}
484484

485-
if (character == 0x130)
486-
{
487-
output_buffer_p[0] = LIT_CHAR_LOWERCASE_I;
488-
output_buffer_p[1] = 0x307;
489-
return 2;
490-
}
491-
492485
output_buffer_p[0] = character;
493486
return 1;
494487
} /* lit_char_to_lower_case */
@@ -516,21 +509,6 @@ lit_char_to_upper_case (ecma_char_t character, /**< input character value */
516509
return 1;
517510
}
518511

519-
if (character == 0xdf)
520-
{
521-
output_buffer_p[0] = LIT_CHAR_UPPERCASE_S;
522-
output_buffer_p[1] = LIT_CHAR_UPPERCASE_S;
523-
return 2;
524-
}
525-
526-
if (character == 0x1fd7)
527-
{
528-
output_buffer_p[0] = 0x399;
529-
output_buffer_p[1] = 0x308;
530-
output_buffer_p[2] = 0x342;
531-
return 3;
532-
}
533-
534512
output_buffer_p[0] = character;
535513
return 1;
536514
} /* lit_char_to_upper_case */

tests/jerry/string-upper-lower-case-conversion.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ assert ("0123456789abcdefghijklmnopqrstuvwxzyABCDEFGHIJKLMNOPQRSTUVWXYZ".toLower
2020
assert ("0123456789abcdefghijklmnopqrstuvwxzyABCDEFGHIJKLMNOPQRSTUVWXYZ".toUpperCase()
2121
== "0123456789ABCDEFGHIJKLMNOPQRSTUVWXZYABCDEFGHIJKLMNOPQRSTUVWXYZ");
2222

23-
assert ("\u0130".toLowerCase() == "i\u0307");
24-
assert ("\xdf".toUpperCase() == "SS");
25-
assert ("\u1fd7".toUpperCase() == "\u0399\u0308\u0342");
26-
27-
assert ("H\u0130-+".toLowerCase() == "hi\u0307-+");
28-
assert ("\xdf\u1fd7\xdf".toUpperCase() == "SS\u0399\u0308\u0342SS");
29-
assert ("\u0130\u0130\u0130".toLowerCase() == "i\u0307i\u0307i\u0307");
30-
3123
// Although codepoint 0x10400 and 0x10428 are an upper-lowercase pair,
3224
// we must not do their conversion in JavaScript. We must also ignore
3325
// stray surrogates.

0 commit comments

Comments
 (0)