Skip to content

Commit d5efae9

Browse files
committed
Math.sign and Math.trunc
JerryScript-DCO-1.0-Signed-off-by: Örkényi Virág orkvi@inf.u-szeged.hu
1 parent f6f52a2 commit d5efae9

File tree

6 files changed

+150
-1
lines changed

6 files changed

+150
-1
lines changed

jerry-core/ecma/builtin-objects/ecma-builtin-math.c

Lines changed: 83 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,16 @@ enum
5555
ECMA_MATH_OBJECT_EXP, /* ECMA-262 v5, 15.8.2.8 */
5656
ECMA_MATH_OBJECT_FLOOR, /* ECMA-262 v5, 15.8.2.9 */
5757
ECMA_MATH_OBJECT_LOG, /* ECMA-262 v5, 15.8.2.10 */
58+
#if ENABLED (JERRY_ES2015_BUILTIN)
59+
ECMA_MATH_OBJECT_TRUNC, /* ECMA-262 v6, 20.2.2.35 */
60+
#endif /* ENABLED (JERRY_ES2015_BUILTIN) */
5861
ECMA_MATH_OBJECT_ROUND, /* ECMA-262 v5, 15.8.2.15 */
5962
ECMA_MATH_OBJECT_SIN, /* ECMA-262 v5, 15.8.2.16 */
6063
ECMA_MATH_OBJECT_SQRT, /* ECMA-262 v5, 15.8.2.17 */
6164
ECMA_MATH_OBJECT_TAN, /* ECMA-262 v5, 15.8.2.18 */
62-
65+
#if ENABLED (JERRY_ES2015_BUILTIN)
66+
ECMA_MATH_OBJECT_SIGN, /* ECMA-262 v6, 20.2.2.29 */
67+
#endif /* ENABLED (JERRY_ES2015_BUILTIN) */
6368
ECMA_MATH_OBJECT_ATAN2, /* ECMA-262 v5, 15.8.2.5 */
6469
ECMA_MATH_OBJECT_POW, /* ECMA-262 v5, 15.8.2.13 */
6570

@@ -153,6 +158,65 @@ ecma_builtin_math_object_max_min (bool is_max, /**< 'max' or 'min' operation */
153158
return ecma_make_number_value (result_num);
154159
} /* ecma_builtin_math_object_max_min */
155160

161+
#if ENABLED (JERRY_ES2015_BUILTIN)
162+
163+
/**
164+
* The Number.prototype object's 'Math.trunc' routine
165+
*
166+
* See also:
167+
* ECMA-262 v6, 20.2.2.35
168+
*
169+
* @return ecma value
170+
* Returned value must be freed with ecma_free_value.
171+
*/
172+
static ecma_number_t
173+
ecma_builtin_math_object_trunc (ecma_number_t arg)
174+
{
175+
if (ecma_number_is_nan (arg) || ecma_number_is_infinity (arg) || ecma_number_is_zero (arg))
176+
{
177+
return arg;
178+
}
179+
180+
if ((arg > 0) && (arg < 1))
181+
{
182+
return (ecma_number_t) 0;
183+
}
184+
185+
if ((arg < 0) && (arg > -1))
186+
{
187+
return (ecma_number_t) -0;
188+
}
189+
190+
return (ecma_number_t) arg - fmod (arg,1);
191+
} /* ecma_builtin_math_object_trunc */
192+
193+
/**
194+
* The Number.prototype object's 'Math.sign' routine
195+
*
196+
* See also:
197+
* ECMA-262 v6, 20.2.2.29
198+
*
199+
* @return ecma value
200+
* Returned value must be freed with ecma_free_value.
201+
*/
202+
static ecma_number_t
203+
ecma_builtin_math_object_sign (ecma_number_t arg)
204+
{
205+
if (ecma_number_is_nan (arg) || ecma_number_is_zero (arg))
206+
{
207+
return arg;
208+
}
209+
210+
if (ecma_number_is_negative (arg))
211+
{
212+
return (ecma_number_t) -1.0;
213+
}
214+
215+
return (ecma_number_t) 1.0;
216+
} /* ecma_builtin_math_object_sign */
217+
218+
#endif /* ENABLED (JERRY_ES2015_BUILTIN) */
219+
156220
/**
157221
* The Math object's 'random' routine.
158222
*
@@ -282,6 +346,17 @@ ecma_builtin_math_dispatch_routine (uint16_t builtin_routine_id, /**< built-in w
282346
x = DOUBLE_TO_ECMA_NUMBER_T (log (x));
283347
break;
284348
}
349+
350+
#if ENABLED (JERRY_ES2015_BUILTIN)
351+
352+
case ECMA_MATH_OBJECT_TRUNC:
353+
{
354+
x = ecma_builtin_math_object_trunc (x);
355+
break;
356+
}
357+
358+
#endif /* ENABLED (JERRY_ES2015_BUILTIN) */
359+
285360
case ECMA_MATH_OBJECT_ROUND:
286361
{
287362
if (ecma_number_is_nan (x)
@@ -328,6 +403,13 @@ ecma_builtin_math_dispatch_routine (uint16_t builtin_routine_id, /**< built-in w
328403
x = DOUBLE_TO_ECMA_NUMBER_T (tan (x));
329404
break;
330405
}
406+
#if ENABLED (JERRY_ES2015_BUILTIN)
407+
case ECMA_MATH_OBJECT_SIGN:
408+
{
409+
x = ecma_builtin_math_object_sign (x);
410+
break;
411+
}
412+
#endif /* ENABLED (JERRY_ES2015_BUILTIN) */
331413
case ECMA_MATH_OBJECT_ATAN2:
332414
{
333415
x = DOUBLE_TO_ECMA_NUMBER_T (atan2 (x, y));

jerry-core/ecma/builtin-objects/ecma-builtin-math.inc.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,10 @@ ROUTINE (LIT_MAGIC_STRING_ROUND, ECMA_MATH_OBJECT_ROUND, 1, 1)
9191
ROUTINE (LIT_MAGIC_STRING_SIN, ECMA_MATH_OBJECT_SIN, 1, 1)
9292
ROUTINE (LIT_MAGIC_STRING_SQRT, ECMA_MATH_OBJECT_SQRT, 1, 1)
9393
ROUTINE (LIT_MAGIC_STRING_TAN, ECMA_MATH_OBJECT_TAN, 1, 1)
94+
#if ENABLED (JERRY_ES2015_BUILTIN)
95+
ROUTINE (LIT_MAGIC_STRING_SIGN, ECMA_MATH_OBJECT_SIGN, 1, 1)
96+
ROUTINE (LIT_MAGIC_STRING_TRUNC, ECMA_MATH_OBJECT_TRUNC, 1, 1)
97+
#endif /* ENABLED (JERRY_ES2015_BUILTIN) */
9498

9599
#endif /* ENABLED (JERRY_BUILTIN_MATH) */
96100

jerry-core/lit/lit-magic-strings.inc.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,9 @@ LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_PUSH, "push")
160160
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_RACE, "race")
161161
#endif
162162
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_SEAL, "seal")
163+
#if ENABLED (JERRY_BUILTIN_MATH)
164+
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_SIGN, "sign")
165+
#endif
163166
#if ENABLED (JERRY_ES2015_BUILTIN_MAP) \
164167
|| ENABLED (JERRY_ES2015_BUILTIN_SET)
165168
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_SIZE, "size")
@@ -238,6 +241,9 @@ LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_SLICE, "slice")
238241
|| ENABLED (JERRY_ES2015_BUILTIN_SYMBOL)
239242
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_SPLIT, "split")
240243
#endif
244+
#if ENABLED (JERRY_BUILTIN_MATH)
245+
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_TRUNC, "trunc")
246+
#endif
241247
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_VALUE, "value")
242248
#if ENABLED (JERRY_BUILTIN_MATH)
243249
LIT_MAGIC_STRING_DEF (LIT_MAGIC_STRING_LOG10E_U, "LOG10E")

jerry-core/lit/lit-magic-strings.ini

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ LIT_MAGIC_STRING_NEXT = "next"
8383
LIT_MAGIC_STRING_PUSH = "push"
8484
LIT_MAGIC_STRING_RACE = "race"
8585
LIT_MAGIC_STRING_SEAL = "seal"
86+
LIT_MAGIC_STRING_SIGN = "sign"
8687
LIT_MAGIC_STRING_SIZE = "size"
8788
LIT_MAGIC_STRING_SOME = "some"
8889
LIT_MAGIC_STRING_SORT = "sort"
@@ -111,6 +112,7 @@ LIT_MAGIC_STRING_ROUND = "round"
111112
LIT_MAGIC_STRING_SHIFT = "shift"
112113
LIT_MAGIC_STRING_SLICE = "slice"
113114
LIT_MAGIC_STRING_SPLIT = "split"
115+
LIT_MAGIC_STRING_TRUNC = "trunc"
114116
LIT_MAGIC_STRING_VALUE = "value"
115117
LIT_MAGIC_STRING_LOG10E_U = "LOG10E"
116118
LIT_MAGIC_STRING_NUMBER_UL = "Number"

tests/jerry/es2015/math-sign.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
// Copyright JS Foundation and other contributors, http://js.foundation
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
var nan = NaN;
16+
var p_zero = 0.0;
17+
var m_zero = -p_zero;
18+
19+
assert (isNaN(Math['sign'](NaN)));
20+
assert (Math['sign'](p_zero) === p_zero);
21+
assert (Math['sign'](m_zero) === m_zero);
22+
assert (Math['sign'](-5) === -1);
23+
assert (Math['sign'](5) === 1);

tests/jerry/es2015/math-trunc.js

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
// Copyright JS Foundation and other contributors, http://js.foundation
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
var nan = NaN;
16+
var p_zero = 0.0;
17+
var m_zero = -p_zero;
18+
var p_inf = Infinity;
19+
var m_inf = -p_inf;
20+
21+
assert (isNaN(Math['trunc'](NaN)));
22+
assert (Math['trunc'](p_zero) === p_zero);
23+
assert (Math['trunc'](m_zero) === m_zero);
24+
assert (Math['trunc'](p_inf) === p_inf);
25+
assert (Math['trunc'](m_inf) === m_inf);
26+
27+
assert (Math['trunc'](0.5) === p_zero);
28+
assert (Math['trunc'](-0.5) === m_zero);
29+
assert (Math['trunc'](1.2) === 1);
30+
assert (Math['trunc'](-1.5) === -1);
31+
assert (Math['trunc'](65.7) === 65);
32+
assert (Math['trunc'](-24.9) === -24);

0 commit comments

Comments
 (0)