Skip to content

Commit eccfc18

Browse files
authored
Bugfix: The unittest which test the API has failed in case of disabled error-messages (#1470)
and disabled snapshot_exec options. JerryScript-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
1 parent bed094f commit eccfc18

File tree

1 file changed

+22
-19
lines changed

1 file changed

+22
-19
lines changed

tests/unit/test-api.c

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -794,26 +794,29 @@ main (void)
794794
TEST_ASSERT (test_api_is_free_callback_was_called);
795795

796796
/* Test: parser error location */
797-
jerry_init (JERRY_INIT_SHOW_OPCODES);
797+
if (jerry_is_feature_enabled (JERRY_FEATURE_ERROR_MESSAGES))
798+
{
799+
jerry_init (JERRY_INIT_SHOW_OPCODES);
798800

799-
const char *parser_err_src_p = "b = 'hello';\nvar a = (;";
800-
parsed_code_val = jerry_parse ((jerry_char_t *) parser_err_src_p,
801-
strlen (parser_err_src_p),
802-
false);
803-
TEST_ASSERT (jerry_value_has_error_flag (parsed_code_val));
804-
jerry_value_clear_error_flag (&parsed_code_val);
805-
jerry_value_t err_str_val = jerry_value_to_string (parsed_code_val);
806-
jerry_size_t err_str_size = jerry_get_string_size (err_str_val);
807-
jerry_char_t err_str_buf[256];
808-
sz = jerry_string_to_char_buffer (err_str_val, err_str_buf, err_str_size);
809-
err_str_buf[sz] = 0;
810-
811-
jerry_release_value (err_str_val);
812-
jerry_release_value (parsed_code_val);
801+
const char *parser_err_src_p = "b = 'hello';\nvar a = (;";
802+
parsed_code_val = jerry_parse ((jerry_char_t *) parser_err_src_p,
803+
strlen (parser_err_src_p),
804+
false);
805+
TEST_ASSERT (jerry_value_has_error_flag (parsed_code_val));
806+
jerry_value_clear_error_flag (&parsed_code_val);
807+
jerry_value_t err_str_val = jerry_value_to_string (parsed_code_val);
808+
jerry_size_t err_str_size = jerry_get_string_size (err_str_val);
809+
jerry_char_t err_str_buf[256];
810+
sz = jerry_string_to_char_buffer (err_str_val, err_str_buf, err_str_size);
811+
err_str_buf[sz] = 0;
812+
813+
jerry_release_value (err_str_val);
814+
jerry_release_value (parsed_code_val);
815+
TEST_ASSERT (!strcmp ((char *) err_str_buf,
816+
"SyntaxError: Primary expression expected. [line: 2, column: 10]"));
813817

814-
TEST_ASSERT (!strcmp ((char *) err_str_buf,
815-
"SyntaxError: Primary expression expected. [line: 2, column: 10]"));
816-
jerry_cleanup ();
818+
jerry_cleanup ();
819+
}
817820

818821
/* External Magic String */
819822
jerry_init (JERRY_INIT_SHOW_OPCODES);
@@ -863,7 +866,7 @@ main (void)
863866
jerry_cleanup ();
864867

865868
/* Dump / execute snapshot */
866-
if (true)
869+
if (jerry_is_feature_enabled (JERRY_FEATURE_SNAPSHOT_EXEC))
867870
{
868871
static uint8_t global_mode_snapshot_buffer[1024];
869872
static uint8_t eval_mode_snapshot_buffer[1024];

0 commit comments

Comments
 (0)