Before Hook Promise

[richardmatthewsdev]

Hey,

I am having an issue with the before hook on app.coffee where the Roots compilation doesn't appear to wait for the promise to be resolved before compiling.

In an empty Roots project, I would expect that this code would cause Roots to never compile.

axis         = require 'axis'
rupture      = require 'rupture'
autoprefixer = require 'autoprefixer-stylus'
js_pipeline  = require 'js-pipeline'
css_pipeline = require 'css-pipeline'

promise = ->
  return new Promise((resolve, reject) ->

  )

module.exports =
  ignores: ['readme.md', '**/layout.*', '**/_*', '.gitignore', 'ship.*conf']

  extensions: [
    js_pipeline(files: 'assets/js/*.coffee'),
    css_pipeline(files: 'assets/css/*.styl')
  ]

  stylus:
    use: [axis(), rupture(), autoprefixer()]
    sourcemap: true

  'coffee-script':
    sourcemap: true

  before: promise

  jade:
    pretty: true

This is a problem for me because I am trying to fetch content from an API in multiple requests and I am needing Roots to wait until all of the requests have been made before it compiles the site.

Any help would be much appreciated!

Thanks,

[jescalan]

Hey @reinkaos! Thanks for pointing this out. It appears as if this is a bug. I'll have it patched up and a new release out to resolve it shortly 👬

[jescalan]

Hey actually, anyone interested in trying to submit them patch themselves? This is a fairly straightforward change if you understand how promises work 😁

This is the method that needs to be slightly retooled: https://github.com/jescalan/roots/blob/master/lib/api/compile.coffee#L106

Basically, W.resolve should be used here instead of lift

[richardmatthewsdev]

Hey @jescalan thanks for getting back to me, I look forward to this issue being fixed :).