Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on client side when no tags or trackers are defined on master #522

Closed
alexandresoro opened this issue Mar 9, 2022 · 0 comments
Closed

Comments

@alexandresoro
Copy link
Contributor

alexandresoro commented Mar 9, 2022

Your Environment

  • Version used:
    • Master branch
    • Commit ID (development release) : e368cac
  • Environment name and version:
    • Node.js version 16.14.0
    • npm version 8.3.1
    • Web browser Chrome
  • Operating system and version: any
  • Torrent client and version: rtorrent

Summary

With the introduction of the features from #519 , I have noticed that the overview page no longer works locally with no torrents. I have narrowed down the issue to the changes related to collapsible elements, and more precisely to the useState hooks that are declared after the components Tag filters and Tracker filters have returned when empty.
This is a break of the rules of hooks that state that the list of hooks should always be the same and in the same order with every render.

Expected Behavior

Page should be displayed properly

Current Behavior

Page remains with a blue background

Capture d’écran 2022-03-09 à 23 40 04

Possible Solution

#523

Steps to Reproduce

  1. Launch the latest version of master on any environment
  2. Start a fresh torrent session with no torrents
  3. Log in with any working user

Context

@jesec jesec closed this as completed in f7d5fff Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant