fixup! feat: add fork remote command

Remove unnecessary error checks:
- forkUsername needn't be checked because as of PR #5043, the result of a Prompt
  call can no longer be an empty string
- if the originUrl is empty for some reason, this will be caught by the
  "unsupported or invalid remote URL" error check below, which is good enough
  for this very unlikely case.

Author: stefanhaller

pkg/gui/controllers/remotes_controller.go

@@ -221,13 +221,6 @@ var urlRegex = regexp.MustCompile(`^(git@[^:]+:|ssh://[^/]+/|https?://[^/]+/)([^
 // Rewrites a Git remote URL to use the given fork username,
 // keeping the repo name and host intact. Supports SCP-like SSH, SSH URL style, and HTTPS.
 func replaceForkUsername(originUrl, forkUsername string) (string, error) {
-	if forkUsername == "" {
-		return "", errors.New("fork username cannot be empty")
-	}
-	if originUrl == "" {
-		return "", errors.New("remote URL cannot be empty")
-	}
-
 	if urlRegex.MatchString(originUrl) {
 		return urlRegex.ReplaceAllString(originUrl, "${1}"+forkUsername+"/$3$4"), nil
 	}

pkg/gui/controllers/remotes_controller_test.go

@@ -108,11 +108,6 @@ func TestReplaceForkUsername_Errors(t *testing.T) {
 		in       string
 		forkUser string
 	}{
-		{
-			name:     "empty fork user",
-			in:       "git@github.com:old/repo.git",
-			forkUser: "",
-		},
 		{
 			name:     "https host only",
 			in:       "https://github.com",
@@ -143,6 +138,11 @@ func TestReplaceForkUsername_Errors(t *testing.T) {
 			in:       "ftp://github.com/old/repo.git",
 			forkUser: "x",
 		},
+		{
+			name:     "empty url",
+			in:       "",
+			forkUser: "x",
+		},
 	}
 
 	for _, c := range cases {