DiffableDataSource: use weak self in _applyDiffSnapshot completion handler #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines? 🖤
Closes #125
Describe your changes
As discussed in the issue, this fixes a crash with
Fatal error: Attempted to read an unowned reference but the object was already deallocated
when the collection view disappears from the view hierarchy while the animation is still in progress.Repro: https://github.com/lachenmayer/ReactiveCollectionsKitCrashRepro
Expected behavior: collection view appears & disappears a couple of times, and then the app crashes.
Repro with applied fix: https://github.com/lachenmayer/ReactiveCollectionsKitCrashRepro/tree/apply-fix
Expected behavior: collection view continuous to appear & disappear without a crash.