Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose UIScrollViewDelegate to clients #131

Closed
jessesquires opened this issue Sep 25, 2024 · 0 comments · Fixed by #133
Closed

Expose UIScrollViewDelegate to clients #131

jessesquires opened this issue Sep 25, 2024 · 0 comments · Fixed by #133
Labels
feature request

Comments

@jessesquires
Copy link
Owner

There are valid cases to need to implement UIScrollViewDelegate. Unfortunately, UICollectionViewDelegate inherits from UIScrollViewDelegate. (Such a terrible design.) This means clients currently have no way to implement UIScrollViewDelegate methods, because CollectionViewDriver is the collection view's delegate. If clients steal the delegate, then Bad Things™ happen.

Todo:

  • Allow clients to set a weak var scrollViewDelegate: UIScrollViewDelegate? on CollectionViewDriver
  • Implement the UIScrollViewDelegate methods in CollectionViewDriver and forward them to this delegate
ruddfawcett added a commit to ruddfawcett/ReactiveCollectionsKit that referenced this issue Sep 29, 2024
@ruddfawcett
Exposes to clients per jessesquires#131
e23ff7a
@ruddfawcett ruddfawcett mentioned this issue Sep 29, 2024
Merged
jessesquires pushed a commit to ruddfawcett/ReactiveCollectionsKit that referenced this issue Oct 2, 2024
@ruddfawcett @jessesquires
Exposes to clients per jessesquires#131
0361dd9
jessesquires pushed a commit to ruddfawcett/ReactiveCollectionsKit that referenced this issue Oct 2, 2024
@ruddfawcett @jessesquires
Exposes to clients per jessesquires#131
0d5705e
jessesquires pushed a commit to ruddfawcett/ReactiveCollectionsKit that referenced this issue Oct 2, 2024
@ruddfawcett @jessesquires
Exposes to clients per jessesquires#131
c584fea
jessesquires added a commit that referenced this issue Oct 3, 2024
@jessesquires
Add scroll view tests for #133, #131
56c3868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exposes UIScrollViewDelegate to clients ruddfawcett/ReactiveCollectionsKit
1 participant
@jessesquires