-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(prefer-importing-jest-globals): stop collecting import specifiers for no reason #1646
perf(prefer-importing-jest-globals): stop collecting import specifiers for no reason #1646
Conversation
Can you explain why this isn't needed? It must have been being covered by at least one test so it can't have been unused, though the fact that our suite still passes would suggest it's not needed but it would be good to understand why |
I have two thoughts about that, the variables |
Oh I see, we're only ever writing to |
## [28.8.2](v28.8.1...v28.8.2) (2024-09-02) ### Performance Improvements * **prefer-importing-jest-globals:** stop collecting import specifiers for no reason ([#1646](#1646)) ([0660242](0660242))
🎉 This issue has been resolved in version 28.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pr is to remove unused
ImportDeclaration
check.