Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(no-test-prefixes): add case for xdescribe.each #780

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 6, 2021

#722 fixed the first half of #776 - this is just adding an explicit test case for this situation.

Fixes #776

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does test trigger a release?

@G-Rath
Copy link
Collaborator Author

G-Rath commented Mar 6, 2021

No it shouldn't - semantic-release should only trigger on fix, feat, and changes marked as breaking:

The commit analyzer that ships with semantic-release only catches fix and feat commits (#12).

semantic-release/commit-analyzer#12

@SimenB
Copy link
Member

SimenB commented Mar 6, 2021

good stuff 👍

@G-Rath G-Rath merged commit 92a8826 into main Mar 6, 2021
@G-Rath G-Rath deleted the add-test-case branch March 6, 2021 19:35
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

🎉 This PR is included in version 24.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 7, 2021
This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autofix for xdescribe.each is wrong
2 participants