Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get to 100% test coverage #86

Closed
SimenB opened this issue Feb 17, 2018 · 5 comments
Closed

Get to 100% test coverage #86

SimenB opened this issue Feb 17, 2018 · 5 comments
Labels
help wanted

Comments

@SimenB
Copy link
Member

SimenB commented Feb 17, 2018

In #67 thresholds were added, but I was unable to set them at 100 as we don't have coverage. Help reaching it would be greatly appreciated!
@ranyitz ranyitz mentioned this issue Feb 21, 2018
Merged
@SimenB
Copy link
Member Author

SimenB commented Feb 21, 2018

With #88 we're getting really close! Only a couple of branches left

@tushardhole
Copy link
Contributor

@SimenB I will look into missing branch coverage for valid-expect-in-promise.js

@tushardhole
Copy link
Contributor

@SimenB I will also check remaining files for 100% coverage.

@tushardhole
Copy link
Contributor

Created PR here

@SimenB
Copy link
Member Author

SimenB commented Feb 22, 2018

Woo! ❤️

@SimenB SimenB closed this as completed Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @tushardhole