Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No visual difference" message outputting with color #130

Closed
alistairjcbrown opened this issue May 7, 2020 · 2 comments
Closed

"No visual difference" message outputting with color #130

alistairjcbrown opened this issue May 7, 2020 · 2 comments

Comments

@alistairjcbrown
Copy link
Contributor

This is more to note the regression than an issue to can be solved in this repo, other than rolling back the PR - looks like some of the diff output messages aren't controlled by the color options - https://github.com/facebook/jest/blob/4bd3d4a05999170f423f7050d4e0537648499e88/packages/jest-diff/src/constants.ts#L10-L11
jest-diff is using chalk.dim directly, rather than making use of the commonColor option which we're turning off when color is set to false (from PR #123).

The issue I'm seeing after upgrading is that we're getting a diff with color codes when running Jest normally (no colors when running CI=true)
image

@thymikee
Copy link
Member

thymikee commented May 7, 2020

Sounds like something that should be fixed upstream. Mind sending a PR?

@thymikee
Copy link
Member

thymikee commented May 7, 2020

Closing this in favor of #129 :)

@SimenB SimenB closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants