Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide code comments in generated HTML #40

Open
RossBoylan opened this issue Nov 16, 2024 · 1 comment
Open

Unhide code comments in generated HTML #40

RossBoylan opened this issue Nov 16, 2024 · 1 comment

Comments

@RossBoylan
Copy link
Contributor

I disagree with the rationale for #38, and the effects of the associated code changes.

Sometimes I put in code comments that are very specific to a particular line; sometimes I adopt code that was not originally in literate. In both cases it would be useful to me to see the comments in the preview; it was surprising when they weren't there.

Perhaps an intermediate solution would be to add an option that controlled whether or not code comments are tossed for HTML.

If you decide to retain the feature anyway, it might be better to eat the comments completely. The whitespace associated with them remains in the HTML output, which is a little weird. I haven't been able to trace exactly how that happens. Perhaps the data-line value in, e.g., <code data-line="233"... is actually controlling the vertical position, and is set before the comment is removed.

@jesterKing
Copy link
Owner

An option would be useful here indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants